expicitly commit db operations in shuttle#351
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 81.87% 81.86% -0.01%
==========================================
Files 60 60
Lines 3205 3209 +4
Branches 334 334
==========================================
+ Hits 2624 2627 +3
- Misses 485 486 +1
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benoit74
left a comment
There was a problem hiding this comment.
Please extend this to the mill.
Is this really working when you have multiple "things" to process? I thought SQLAlchemy would complain you have commit the session and trying to do modifications afterwards ... Does SQLAlchemy automatically reopen a new session implicitely?
I did try it for one book by making a backup. Verifying with multiple objects |
|
Tried it and it worked. Sent notifications by wiping the DB and re-processing [2026-06-22 14:31:00,061: DEBUG] Executing task: process_zimfarm_notifications
[2026-06-22 14:31:00,061: INFO] Processing Zimfarm notifications
[2026-06-22 14:31:00,063: DEBUG] Processing Zimfarm notification e38ae7b2-dd4d-4670-9932-0567f62f27ee
[2026-06-22 14:31:00,127: DEBUG] Processing Zimfarm notification 82dc63ef-6a32-4977-9692-3aa63c99bdf9
[2026-06-22 14:31:00,147: DEBUG] Processing Zimfarm notification ee8a009b-8548-4504-bde8-c727c5abd123
[2026-06-22 14:31:00,154: INFO] Done processing 3 Zimfarm notifications
[2026-06-22 14:31:00,155: DEBUG] Executing task: process_title_modifications
[2026-06-22 14:31:00,155: INFO] Processing title modification events
[2026-06-22 14:31:00,155: INFO] Done processing 0 title modification events. |
00822e0 to
a6913aa
Compare
a6913aa to
3cc3885
Compare
Changes
commitafter every operationThis fixes #350