Skip to content

Update copy and logic on project access dropdowns#3263

Open
charliepark wants to merge 4 commits into
mainfrom
update_tooltips_on_project_access
Open

Update copy and logic on project access dropdowns#3263
charliepark wants to merge 4 commits into
mainfrom
update_tooltips_on_project_access

Conversation

@charliepark

@charliepark charliepark commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR makes a few changes to the tooltips, buttons, and logic of the Project Access table and each row's action menu dropdown.

First, it updates the logic around whether the user actually has the permissions to make changes to the (users' / groups') permissions. If the user doesn't have the appropriate permissions, the buttons are disabled. Previously, the logic was "does the user/group being investigated currently have a project-level permission?", which doesn't quite cover the same territory and is less useful. So this PR adds a canEditRoles attribute to check against the current user and whether they can make changes here.

Second, this PR changes the verbiage of the dropdown button. For a user/group with a current project role, the menu now says "Change project role". For a user/group without a project role, it now says "Add project role".
Screenshot 2026-06-25 at 3 02 20 PM
Screenshot 2026-06-25 at 3 02 05 PM

In a case where a user has a silo role that supersedes a project role (SILO.ADMIN, PROJECT.COLLABORATOR), the dominant role (SILO.ADMIN) will still render on the table, but the presence of the project role will set the copy to say "Change project role":
Screenshot 2026-06-25 at 3 24 47 PM

(Note: The "project" in "Change/Add project role" is new, but I think an improvement to reinforce the tier of access the admin is analyzing. We might update "Delete" to say "Delete project role" to help in the same way. I'm open to thoughts on that! Similarly, we could change the dropdowns on the Fleet/Silo Access pages to say "fleet role" / "silo role")

Third, when the role has been inherited from the silo (meaning: no project role), there's no way to delete the role from the current view, so the Delete button is disabled and the tooltip now says "This role is inherited from the silo"
Screenshot 2026-06-25 at 3 02 39 PM

Fourth, a subtle change in the change project role form … if the user/group has a project role, that role's radio button is pre-selected in the form (which is unchanged from the current behavior). When the admin is adding a role, meaning there is not currently a project role, no radio buttons are pre-selected.
(changing a role)
Screenshot 2026-06-25 at 4 01 02 PM
(adding a role)
Screenshot 2026-06-25 at 4 00 53 PM
I'm not sure I love the duplication of "project role" in the header and at the top of the radio buttons.

Closes #2963

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Jul 2, 2026 9:19pm

Request Review

@charliepark charliepark changed the title Update copy and some logic on project access dropdowns Update copy and logic on project access dropdowns Jun 26, 2026
@david-crespo

Copy link
Copy Markdown
Collaborator

This is a good direction. I just noticed "Delete" is also problematic — you might read it as "delete user" and be afraid to click it. "Delete role assignment" is too long, but it would be cool if we could come up with something short that conveys that. "Delete assignment" is ok, though "assignment" isn't likely the user's name for it. "Unassign" is pretty ugly but might get the job done? We could leave it as "Delete" and explain on hover, but I don't like that either.

@benjaminleonard

Copy link
Copy Markdown
Contributor
  • "Remove" I guess a synonym for delete but feels different
  • "Remove access"?

@charliepark

Copy link
Copy Markdown
Contributor Author

Since "Add project role" and "Change project role" seem good, what about just using "Remove project role"?

@charliepark

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-07-02 at 2 17 58 PM

@david-crespo

Copy link
Copy Markdown
Collaborator

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading disabled tooltip on change role button

3 participants