Add missing cosmo temperature sensors#2578
Open
jamesmunns wants to merge 1 commit into
Open
Conversation
jamesmunns
commented
Jun 24, 2026
| rail_controller_notemp!(Core, isl68224, v1p8_sp5_a1, A0), // XXX A0 or A2? | ||
| rail_controller_notemp!(Core, isl68224, v3p3_sp5_a1, A0), // XXX A0 or A2? | ||
| rail_controller!(Core, isl68224, v1p1_sp5_a0, A0), | ||
| rail_controller!(Core, isl68224, v1p8_sp5_a1, A0), // XXX A0 or A2? |
Contributor
Author
There was a problem hiding this comment.
@mkeeter do we know better now whether this should be A0 or A2?
Collaborator
There was a problem hiding this comment.
I think it should be A2, because the chip generates the A0 rail (but is itself powered by A2 rails). We should test it, though!
Contributor
Author
There was a problem hiding this comment.
Is there a specific way you'd suggest to test this, or just "make the change and see if a cosmo sled still boots happily about it"?
Collaborator
There was a problem hiding this comment.
Basically! Make the change above (with A2 instead of A0), put a Cosmo sled into A2 (humility hiffy -c Sequencer.set_state -a state=A2), and confirm that it's still happily reading temperatures (with humility sensors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2577.
This is a similar change to #2108, but for Cosmo instead of gimlet. I took a look, and the only other apps with this ISL sensor are the gimlet-bu target (which has no sensors), and sidecar (which already has these temp sensors mapped).