[nexus] fix flake in instance_start saga's test_action_failure_can_unwind test#10689
Merged
sunshowers merged 1 commit intoJun 30, 2026
Conversation
Created using spr 1.3.6-beta.1
jmpesp
approved these changes
Jun 30, 2026
sunshowers
deleted the
sunshowers/spr/nexus-fix-flake-in-instance_start-sagas-test_action_failure_can_unwind-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the instance_watcher bg task was racing with the saga set up by the test. (This is the "background tasks mutating the SUT" pattern in flake-patterns.adoc.)
Also change the other instance start saga tests to disable the instance watcher task. I couldn't reproduce a similar race with any of them after setting the period to 1 second (lowering the period made test_action_failure_can_unwind very easy to repro), but I think from a test hygiene perspective it makes sense to turn the task off.
Buildomat flake log