Add External API endpoints for BGP unnumbered interface manager status#10705
Open
taspelund wants to merge 3 commits into
Open
Add External API endpoints for BGP unnumbered interface manager status#10705taspelund wants to merge 3 commits into
taspelund wants to merge 3 commits into
Conversation
Now that maghemite has migrated to the RFD 619 convention, it exposes most types via the mg-api-types crate. This crate should have its hash updated alongside mg-admin-client and ddm-admin-client. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
Contributor
Author
|
I have taken this through a4x2 manually and have validated that e2e connectivity works, as do the new endpoints: |
Adds external API endpoints to GET the BGP unnumbered status of interfaces and the unnumbered manager. This provides insights into the Router Discovery state (have we learned about a BGP peer via NDP) and the readiness of an interface that's been configured for BGP unnumbered (does the interface exist in the OS? does it have an IPv6 link-local IP? or is it active?). These are all important when diagnosing failures or delays in the establishment of BGP unnumbered peers, since these are all prerequisites for the BGP FSM to complete connections. This is the omicron side of maghemite#800 Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
4736713 to
654fe27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the omicron side of maghemite#800.
In mgd, we are refactoring the internals of BGP unnumbered which affects the mg-api by no longer requiring the BGP ASN for querying the state... However, omicron never had plumbing to query BGP unnumbered interface state to begin with, which is what this PR remedies.
The new API endpoints are purely status, with no config whatsoever.
The maghemite hash currently points to the feature branch, but will be updated to main once this PR's counterpart lands.