Skip to content

fix: About screen shows "FT8US" instead of "FT8AF"#448

Open
patrickrb with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-settings-about-typo
Open

fix: About screen shows "FT8US" instead of "FT8AF"#448
patrickrb with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-settings-about-typo

Conversation

Copilot AI commented Jul 6, 2026

Copy link
Copy Markdown

The Settings → About screen displayed the hardcoded typo "FT8US" as the app name label instead of "FT8AF".

Changes

  • AboutSettings.kt:91 — replace hardcoded "FT8US" with stringResource(R.string.app_name) so the label stays in sync with the canonical app name:
    // before
    label = "FT8US",
    // after
    label = stringResource(R.string.app_name),
  • AboutAppNameTest.kt (new) — Robolectric regression test asserting R.string.app_name resolves to "FT8AF", guarding against future resource renames or wrong ID references.

Copilot AI changed the title [WIP] Fix typo in app name on Settings > About screen fix: About screen shows "FT8US" instead of "FT8AF" Jul 6, 2026
Copilot AI requested a review from patrickrb July 6, 2026 17:29
@patrickrb patrickrb marked this pull request as ready for review July 6, 2026 21:55
@patrickrb patrickrb requested a review from Copilot July 6, 2026 21:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Settings → About screen app-name label by removing a hardcoded typo ("FT8US") and sourcing the label from the canonical Android string resource (R.string.app_name), plus adds a Robolectric regression test to prevent future regressions.

Changes:

  • Replace hardcoded About screen app name label with stringResource(R.string.app_name).
  • Add a Robolectric unit test asserting R.string.app_name resolves to "FT8AF".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ft8af/app/src/main/kotlin/radio/ks3ckc/ft8af/ui/settings/AboutSettings.kt Uses R.string.app_name for the About screen label instead of a hardcoded string.
ft8af/app/src/test/kotlin/radio/ks3ckc/ft8af/ui/settings/AboutAppNameTest.kt Adds a Robolectric regression test to ensure app_name resolves to the expected value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ft8af/app/src/test/kotlin/radio/ks3ckc/ft8af/ui/settings/AboutAppNameTest.kt Outdated
Comment thread ft8af/app/src/test/kotlin/radio/ks3ckc/ft8af/ui/settings/AboutAppNameTest.kt Outdated
patrickrb and others added 2 commits July 6, 2026 17:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 11.70%. Comparing base (ee76486) to head (dce0bcf).

Files with missing lines Patch % Lines
...in/radio/ks3ckc/ft8af/ui/settings/AboutSettings.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #448   +/-   ##
=========================================
  Coverage     11.70%   11.70%           
  Complexity      113      113           
=========================================
  Files            85       85           
  Lines         11691    11691           
  Branches       2110     2110           
=========================================
  Hits           1369     1369           
  Misses        10191    10191           
  Partials        131      131           
Files with missing lines Coverage Δ
...in/radio/ks3ckc/ft8af/ui/settings/AboutSettings.kt 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings > About shows "FT8US" instead of "FT8AF"

3 participants