chore(ArrowRightIcon): Update any uses of FA arrow right icon to RH brand arrow right icon#12365
Merged
Merged
Conversation
…and arrow right icon
tlabaj
requested review from
a team,
nicolethoen and
wise-king-sullyman
and removed request for
a team
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughReplaced ChangesIcon replacement across examples, demos, and SearchInput
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12365.surge.sh A11y report: https://pf-react-pr-12365-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-core/src/components/Button/examples/ButtonCallToAction.tsx`:
- Line 2: The import of RhUiCaretRightIcon uses a non-standard nested path;
update the import in ButtonCallToAction.tsx to the standard pattern by importing
RhUiCaretRightIcon from
'@patternfly/react-icons/dist/esm/icons/rh-ui-caret-right-icon' (replace the
current
'@patternfly/react-icons/icons/caret-right-icon/dist/esm/icons/rh-ui-caret-right-icon'
import) so it matches other Button examples and the Button.md usage.
In `@packages/react-core/src/components/SearchInput/SearchInput.tsx`:
- Line 11: The import path for RhUiCaretRightIcon in SearchInput.tsx is
malformed—remove the extraneous "/icons/caret-right-icon/" segment so it matches
the other PatternFly icon imports; update the import statement that references
RhUiCaretRightIcon (used by the SearchInput component) to the correct module
path (e.g., '@patternfly/react-icons/dist/esm/icons/rh-ui-caret-right-icon') so
module resolution succeeds.
In `@packages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx`:
- Line 23: The import at the top incorrectly pulls RhUiCaretRightIcon from
'arrow-right-icon'; update the import to use the correct module
'rh-ui-caret-right-icon' so the RhUiCaretRightIcon symbol used in
CardHorizontalGrid (affecting usages at the render locations that reference
RhUiCaretRightIcon around the blocks near lines 137, 165, 196, 230) resolves to
the intended asset. Ensure the import statement exports the RhUiCaretRightIcon
identifier (same name) from
'@patternfly/react-icons/dist/esm/icons/rh-ui-caret-right-icon' and remove the
incorrect 'arrow-right-icon' path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 44cf94ba-f9fc-44b4-b3a9-3bd6914a5beb
⛔ Files ignored due to path filters (1)
packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (7)
packages/react-core/src/components/Accordion/examples/Accordion.mdpackages/react-core/src/components/Accordion/examples/AccordionBordered.tsxpackages/react-core/src/components/Button/examples/Button.mdpackages/react-core/src/components/Button/examples/ButtonCallToAction.tsxpackages/react-core/src/components/Nav/examples/Nav.mdpackages/react-core/src/components/SearchInput/SearchInput.tsxpackages/react-core/src/demos/examples/Card/CardHorizontalGrid.tsx
kmcfaul
reviewed
Apr 22, 2026
kmcfaul
left a comment
kmcfaul
left a comment
Contributor
There was a problem hiding this comment.
Should this be "microns" or "ui" set?
Contributor
Author
@kmcfaul How do I find that out? What are micron vs ui set? |
|
@kmcfaul @tlabaj I left a similar comment on another issue. we're currently adding documentation to call out the difference between the ui and micron sets. I don't think we've come up with anything concrete, such as "use microns when...". the micron set is a lot smaller, so I do think in most use cases we want to use the micron version of the icon if it exists. tagging @andrew-ronaldson for his input |
3 tasks
3 tasks
kmcfaul
approved these changes
Jun 10, 2026
thatblindgeye
approved these changes
Jun 11, 2026
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: towards #12244
Replaced
ArrowRightIconwith Red Hat UIRhUiCaretRightIconwherever the legacy arrow-right icon was used.Changes
SearchInput: Advanced-search action iconSearchInputsnapshot updates for the new SVG outputSummary by CodeRabbit
Closes #12394