feat(icons): add classes to rh sets by kmcfaul · Pull Request #12447 · patternfly/patternfly-react

kmcfaul · 2026-06-11T15:36:17Z

What: Closes #

Adds classes for ui and microns sets.

Summary by CodeRabbit

Bug Fixes
- Red Hat icon components now include proper CSS class names for correct visual styling and theming consistency.

coderabbitai · 2026-06-11T15:36:33Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (65)

packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/AboutModal/__tests__/__snapshots__/AboutModalBoxCloseButton.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertActionCloseButton.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Alert/__tests__/Generated/__snapshots__/AlertIcon.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Alert/__tests__/__snapshots__/AlertActionCloseButton.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/BackToTop/__tests__/__snapshots__/BackToTop.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Breadcrumb/__tests__/__snapshots__/Breadcrumb.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Card/__tests__/__snapshots__/CardHeader.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/ClipboardCopy/__tests__/__snapshots__/ClipboardCopyButton.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/ClipboardCopy/__tests__/__snapshots__/ClipboardCopyToggle.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/DataList/__tests__/Generated/__snapshots__/DataListToggle.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/DataList/__tests__/__snapshots__/DataListToggle.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Drawer/__tests__/__snapshots__/Drawer.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/EmptyState/__tests__/Generated/__snapshots__/EmptyStateIcon.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/EmptyState/__tests__/__snapshots__/EmptyState.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/ExpandableSection/__tests__/__snapshots__/ExpandableSection.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Form/__tests__/__snapshots__/FormFieldGroup.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Icon/__tests__/__snapshots__/Icon.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/JumpLinks/__tests__/__snapshots__/JumpLinks.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Label/__tests__/__snapshots__/Label.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Label/__tests__/__snapshots__/LabelGroup.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Modal/__tests__/__snapshots__/ModalContent.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatus.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/MultipleFileUpload/__tests__/__snapshots__/MultipleFileUploadStatusItem.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Nav/__tests__/Generated/__snapshots__/NavExpandable.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Nav/__tests__/__snapshots__/Nav.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/NotificationBadge/__tests__/__snapshots__/NotificationBadge.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/NotificationDrawer/__tests__/__snapshots__/NotificationDrawerGroup.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/NotificationDrawer/__tests__/__snapshots__/NotificationDrawerListItemHeader.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/NumberInput/__tests__/__snapshots__/NumberInput.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationNavigation.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Popover/__tests__/Generated/__snapshots__/PopoverCloseButton.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Progress/__tests__/Generated/__snapshots__/ProgressContainer.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/components/Progress/__tests__/__snapshots__/Progress.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Switch/__tests__/__snapshots__/Switch.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Tabs/__tests__/__snapshots__/OverflowTab.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Tabs/__tests__/__snapshots__/Tabs.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/TextInput/__tests__/__snapshots__/TextInput.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewListItem.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewSearch.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/Chip/__tests__/__snapshots__/Chip.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalBoxTitle.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/Modal/__tests__/__snapshots__/ModalContent.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/Tile/__tests__/__snapshots__/Tile.test.tsx.snap is excluded by !**/*.snap
packages/react-core/src/deprecated/components/Wizard/__tests__/Generated/__snapshots__/WizardToggle.test.tsx.snap is excluded by !**/*.snap, !**/generated/**
packages/react-core/src/deprecated/components/Wizard/__tests__/__snapshots__/Wizard.test.tsx.snap is excluded by !**/*.snap
packages/react-drag-drop/src/components/DragDrop/__tests__/__snapshots__/DragDrop.test.tsx.snap is excluded by !**/*.snap
packages/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap is excluded by !**/*.snap
packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap is excluded by !**/*.snap
packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap is excluded by !**/*.snap
packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap is excluded by !**/*.snap
packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap is excluded by !**/*.snap
packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 489a62c8-e753-4008-a638-0363bde29abb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The PR updates Red Hat icon definitions to include CSS class metadata. The parseRHIcons.mjs script is configured to emit svgClassName values for ui and microns icon types, and all rh-microns-* icons in the exported icon map are updated with the corresponding 'pf-v6-icon-rh-microns' class name.

Changes

RH Icon SVG Class Names

Layer / File(s)	Summary
Icon type class mapping `packages/react-icons/scripts/parseRHIcons.mjs`	`ICON_TYPE_CLASSES` mapping now assigns `'pf-v6-icon-rh-ui'` and `'pf-v6-icon-rh-microns'` class names for `ui` and `microns` icon types (previously empty strings), enabling these class names to be emitted during module generation.
Microns icon exports with class names `packages/react-icons/scripts/icons/rhIconsMicrons.mjs`	All `rh-microns-*` icon definitions in the exported default icon map now include `svgClassName: 'pf-v6-icon-rh-microns'` alongside existing offset, sizing, and path data fields.

Possibly related PRs

patternfly/patternfly-react#12387: Both PRs modify packages/react-icons/scripts/icons/rhIconsMicrons.mjs microns icon export entries, with direct overlap at the icon-mapping level.
patternfly/patternfly-react#12320: Both PRs modify the icon code-generation path to emit svgClassName metadata for RH icon types, consumed by icon class-name composition logic.
patternfly/patternfly-react#12245: Updates generated icon metadata to emit svgClassName so subsequent styling and rendering work can apply the expected classes.

Suggested labels

Needs design review

Suggested reviewers

nicolethoen
thatblindgeye

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding CSS classes to Red Hat icon sets (rh-microns and rh-ui icons).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

patternfly-build · 2026-06-11T15:40:23Z

Preview: https://pf-react-pr-12447.surge.sh

A11y report: https://pf-react-pr-12447-a11y.surge.sh

feat(icons): add classes to rh sets

2b74e23

update snaps

7a29e37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(icons): add classes to rh sets#12447

feat(icons): add classes to rh sets#12447
kmcfaul wants to merge 2 commits into
patternfly:mainfrom
kmcfaul:rh-icon-classes

kmcfaul commented Jun 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Review skipped

Uh oh!

patternfly-build commented Jun 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kmcfaul commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Estimated code review effort

Uh oh!

patternfly-build commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kmcfaul commented Jun 11, 2026 •

edited

Loading

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

patternfly-build commented Jun 11, 2026 •

edited

Loading