Skip to content

fix(react-icons): move tslib to deps#12454

Open
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:icons-deps
Open

fix(react-icons): move tslib to deps#12454
kmcfaul wants to merge 1 commit into
patternfly:mainfrom
kmcfaul:icons-deps

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

What: Closes #

Fixes a runtime error when react-icons is used directly. This will match our other code packages which also have tslib as a dependency (core, charts, table, templates, code-editor).

Summary by CodeRabbit

  • Chores
    • Updated runtime dependencies in the react-icons package to ensure required utilities are available during execution.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b9ef838-bf3c-4ab1-8dbc-87a94d2b8263

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and c3fafd0.

📒 Files selected for processing (1)
  • packages/react-icons/package.json

Walkthrough

The react-icons package.json is updated to move tslib from the development dependencies block to the runtime dependencies block, making it a required dependency for consumers of the package rather than a development-only tool.

Changes

tslib Runtime Dependency Migration

Layer / File(s) Summary
Move tslib to dependencies
packages/react-icons/package.json
tslib is relocated from devDependencies to dependencies, changing it from development-only to a runtime dependency. The devDependencies block is updated accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving tslib from devDependencies to dependencies in the react-icons package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants