Skip to content

fix(ClipboardIcon): Replace ClipboardIcon with RhUiClipboardFillIcon #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ClipboardIcon): Replace ClipboardIcon with RhUiClipboardFillIcon #12455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Menu/examples/Menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ouia: true

import { Fragment, createRef, useEffect, useRef, useState } from 'react';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState } from 'react';
import { Menu, MenuContent, MenuGroup, MenuList, MenuItem, MenuItemAction } from '@patternfly/react-core';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';

Expand Down Expand Up @@ -54,7 +54,7 @@ export const MenuWithActions: React.FunctionComponent = () => {
</MenuItem>
<MenuItem
isSelected={selectedItems.indexOf(2) !== -1}
actions={<MenuItemAction icon={<ClipboardIcon />} actionId="copy" aria-label="Copy" />}
actions={<MenuItemAction icon={<RhUiClipboardFillIcon />} actionId="copy" aria-label="Copy" />}
itemId={2}
>
Item 3
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/Menu/examples/MenuWithFavorites.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Fragment, useState } from 'react';
import { Menu, MenuContent, MenuItem, MenuItemAction, MenuGroup, MenuList, Divider } from '@patternfly/react-core';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';

export const MenuWithFavorites: React.FunctionComponent = () => {
Expand Down Expand Up @@ -39,7 +39,7 @@ export const MenuWithFavorites: React.FunctionComponent = () => {
text: 'Item 2',
description: 'Description 2',
itemId: 'item-2',
action: <ClipboardIcon />,
action: <RhUiClipboardFillIcon />,
actionId: 'clipboard'
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/TreeView/examples/TreeView.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ propComponents: ['TreeView', 'TreeViewDataItem', 'TreeViewSearch']
---

import { Fragment, useEffect, useState } from 'react';
import { FolderIcon, FolderOpenIcon, EllipsisVIcon, ClipboardIcon, HamburgerIcon, GitlabIcon, GithubIcon, GoogleIcon } from '@patternfly/react-icons';
import { FolderIcon, FolderOpenIcon, EllipsisVIcon, HamburgerIcon, GitlabIcon, GithubIcon, GoogleIcon, RhUiClipboardFillIcon } from '@patternfly/react-icons';

## Examples

Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
MenuToggle,
TreeViewDataItem
} from '@patternfly/react-core';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import HamburgerIcon from '@patternfly/react-icons/dist/esm/icons/hamburger-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';

Expand Down Expand Up @@ -71,7 +71,7 @@ export const TreeViewWithActionItems: React.FunctionComponent = () => {
{
name: 'Application 1',
id: 'example7-App1',
action: <Button variant="plain" aria-label="Launch app 1" icon={<ClipboardIcon />} />,
action: <Button variant="plain" aria-label="Launch app 1" icon={<RhUiClipboardFillIcon />} />,
actionProps: {
'aria-label': 'Launch app 1'
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/CustomMenus/CustomMenus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-i
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';
import ThIcon from '@patternfly/react-icons/dist/esm/icons/th-icon';
import brandImg from '../assets/PF-IconLogo.svg';
Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useRef, useState } from 'react';
import { MenuToggle, MenuItemAction, Select, SelectGroup, SelectList, SelectOption } from '@patternfly/react-core';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';

Expand Down Expand Up @@ -69,7 +69,7 @@ export const ActionsMenuDemo: React.FunctionComponent = () => {
</SelectOption>
<SelectOption
isSelected={selectedItems.includes(2)}
actions={<MenuItemAction icon={<ClipboardIcon />} actionId="copy" aria-label="Copy" />}
actions={<MenuItemAction icon={<RhUiClipboardFillIcon />} actionId="copy" aria-label="Copy" />}
value={2}
>
Item 3
Expand Down
6 changes: 3 additions & 3 deletions packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import LayerGroupIcon from '@patternfly/react-icons/dist/esm/icons/layer-group-icon';
import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon';
import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon';
import ClipboardIcon from '@patternfly/react-icons/dist/esm/icons/clipboard-icon';
import RhUiClipboardFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-clipboard-fill-icon';
import TableIcon from '@patternfly/react-icons/dist/esm/icons/table-icon';
import styles from '@patternfly/react-styles/css/components/Menu/menu';

Expand Down Expand Up @@ -470,7 +470,7 @@ export class MenuDemo extends Component {
</MenuItem>
<MenuItem
isSelected={selectedItems.indexOf(2) !== -1}
actions={<MenuItemAction icon={<ClipboardIcon />} actionId="copy" aria-label="Copy" />}
actions={<MenuItemAction icon={<RhUiClipboardFillIcon />} actionId="copy" aria-label="Copy" />}
itemId={2}
>
Item 3
Expand Down Expand Up @@ -505,7 +505,7 @@ export class MenuDemo extends Component {
text: 'Item 2',
description: 'Description 2',
itemId: 'item-2',
action: <ClipboardIcon />,
action: <RhUiClipboardFillIcon />,
actionId: 'clipboard'
},
{
Expand Down
Loading