Updates for Magento#116
Open
adumont-payplug wants to merge 1 commit into
Open
Conversation
esprit-dev
force-pushed
the
hosted-fields-magento
branch
7 times, most recently
from
d139b5b to
64174d4
Compare
esprit-dev
force-pushed
the
hosted-fields-magento
branch
from
64174d4 to
29469f2
Compare
esprit-dev
force-pushed
the
hosted-fields-magento
branch
from
29469f2 to
d77d723
Compare
adumont-payplug
force-pushed
the
hosted-fields-magento
branch
from
d77d723 to
4a52c28
Compare
jhoaraupp
approved these changes
Jun 18, 2026
ilajili
reviewed
Jun 18, 2026
| ]; | ||
|
|
||
| $captures = array_filter($data['DATA'], static function (array $row) { | ||
| $isCaptureTransaction = $row['OPERATIONTYPE'] === 'capture'; |
Contributor
There was a problem hiding this comment.
Suggested change
| $isCaptureTransaction = $row['OPERATIONTYPE'] === 'capture'; | |
| $isCaptureTransaction = !empty($row['OPERATIONTYPE']) && $row['OPERATIONTYPE'] === 'capture'; |
|
|
||
| $captures = array_filter($data['DATA'], static function (array $row) { | ||
| $isCaptureTransaction = $row['OPERATIONTYPE'] === 'capture'; | ||
| $isSuccessTransaction = $row['EXECCODE'] === '0000'; |
Contributor
There was a problem hiding this comment.
Suggested change
| $isSuccessTransaction = $row['EXECCODE'] === '0000'; | |
| $isSuccessTransaction = !empty($row['EXECCODE']) && $row['EXECCODE'] === '0000'; |
| ]; | ||
| public $billing = []; | ||
| public $shipping = []; | ||
| public $captureTransactionIds = []; |
Contributor
There was a problem hiding this comment.
garder le snake_case comme les autres propriétés capture_transaction_ids
| public $currency; | ||
| public $created_at; | ||
| public $description; | ||
| public $is_paid; |
Contributor
There was a problem hiding this comment.
public $is_paid = false;
Pour une autorisation pas encore capturée, is_paid n'est jamais assigné et reste null. Les plugins qui testent === false pour détecter un échec ne matchent pas null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.