fix: compose external security scheme refs during bundling (#932)#604
Open
daveshanley wants to merge 2 commits into
Open
fix: compose external security scheme refs during bundling (#932)#604daveshanley wants to merge 2 commits into
daveshanley wants to merge 2 commits into
Conversation
External $refs to security schemes — both bare-file refs and component fragments — were not composed into components.securitySchemes when bundling. Use source-slot context to infer the securityScheme component type, with a shape guard (isSecuritySchemeNode) so bare-file wrapper maps and full OpenAPI documents are not misclassified.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
- Coverage 99.78% 99.77% -0.01%
==========================================
Files 283 283
Lines 34419 34452 +33
==========================================
+ Hits 34345 34376 +31
- Misses 46 48 +2
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External $refs to security schemes — both bare-file refs and component fragments — were not composed into components.securitySchemes when bundling. Use source-slot context to infer the securityScheme component type, with a shape guard (isSecuritySchemeNode) so bare-file wrapper maps and full OpenAPI documents are not misclassified.