docs: staged TLS+pinning rollout for registry transport (H1)#310
Open
TeoSlayer wants to merge 1 commit into
Open
docs: staged TLS+pinning rollout for registry transport (H1)#310TeoSlayer wants to merge 1 commit into
TeoSlayer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design proposal (docs only, no default change) for closing audit finding H1: the
node_id → public_keymapping that all peer-handshake authentication — and badge/recovery trust — rests on is fetched over plaintext TCP by default. TLS+pinning exists but is gated behind-registry-tls -registry-trust=pinned -registry-fingerprint=….Adds
docs/PROPOSAL-h1-tls-pinning-rollout.md.Why this matters (verified in code + against prod)
lookupPeerPubKey→regConn.Lookup(nodeID)→resp["public_key"](pkg/daemon/daemon.go:5674) is the sole source of peer-key truth inkeyexchange/handle.go.common/registry/wire/wire.go:183) — integrity rests entirely on transport.registry.DialPool= plaintext (pkg/daemon/daemon.go:911);-registry-tlsdefaults false.pilotctl(incl. recovery/verify) has no TLS option at all —registry.Dialplaintext (cmd/pilotctl/verify.go:301).34.71.57.205:9000serves plaintext;registry.pilotprotocol.network:443already serves a valid Let's Encrypt cert.What the proposal contains
Do not merge — this is for review/decision. No behaviour changes.