Check liblz4 on Windows#20
Open
asavchkov wants to merge 2 commits into
Open
Conversation
| ['ldd', postgres], | ||
| encoding='utf-8') | ||
| self.is_lz4_enabled = 'liblz4.so' in ldd | ||
| if os.name == 'posix': |
Collaborator
There was a problem hiding this comment.
У os_ops есть функция get_name() - она как раз возвращает это имя с рабочей машины.
Собственно здесь пока это не критично, но testgres из-за таких вещей спотыкался при запуске на настоящей удаленной машине.
Надо этот get_name тоже поправить - прописать тип результата )
| break | ||
| else: | ||
| # Fall back to trying to determine lz4 support via pg_config | ||
| pg_config = testgres.get_pg_config() |
Collaborator
There was a problem hiding this comment.
Разу у нас здесь есть os_ops, его можно передать в get_pg_config )
А лучше вызвать get_pg_config2 - он требует, чтобы ему указали os_ops.
Collaborator
Author
There was a problem hiding this comment.
get_pg_config2 не выведен наружу (видимо, специально), оставил get_pg_config с аргументом os_ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.