Replace usage of old node:url api with WHATWG one in pushgateway.js#744
Open
yvon-morice-wmx wants to merge 2 commits into
Open
Replace usage of old node:url api with WHATWG one in pushgateway.js#744yvon-morice-wmx wants to merge 2 commits into
yvon-morice-wmx wants to merge 2 commits into
Conversation
jdmarshall
requested changes
Jul 1, 2026
|
|
||
| function legacyUrlFromWhatwgUrl(whatwgUrl) { | ||
| const legacyUrl = { | ||
| hash: whatwgUrl.hash, |
Contributor
There was a problem hiding this comment.
If you're going to go through the trouble of unwinding URL->url attribute copying it'd be better off to work with URL internally and just do the jiggery pokery for forwarding the old style requestOptions over the top, so we don't round-trip to the legacyUrlResolve function twice.
yvon-morice-wmx
force-pushed
the
replace-usage-of-legacy-node-url
branch
2 times, most recently
from
5e0afa6 to
88ee2ba
Compare
Signed-off-by: Yvon Morice <yvon.morice@winamax.fr>
Signed-off-by: Yvon Morice <yvon.morice@winamax.fr>
yvon-morice-wmx
force-pushed
the
replace-usage-of-legacy-node-url
branch
from
c8c2194 to
1079eb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #743
Replaces usage of
url.urlParseandurl.resolvefromnode:urlbynew url.Urlfrom same package as these functions have been deprecated and trigger a warning on usage.Changes based on code and documentation available at https://nodejs.org/api/url.html#urlresolvefrom-to and https://github.com/nodejs/userland-migrations/tree/main/recipes/node-url-to-whatwg-url