Reject domains longer than 253 characters#472
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
domain() validated each label (<= 63 chars) but never checked the total length, so a long multi-label name (e.g. 256 chars of valid labels) was accepted, and hostname() inherited the same gap. Enforce the RFC 1035 253-character limit on the textual domain name. Fixes python-validators#413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413.
domain()validated each label ({0,61}+ boundary chars, i.e. ≤ 63 characters per label) but never checked the total length. A name made of several valid-length labels could therefore exceed the RFC 1035 limit and still be accepted, andhostname()— which delegates todomain()— inherited the same gap:The textual representation of a domain name is limited to 253 characters (RFC 1035, one octet of the 255-octet wire limit is the root label). This adds that check to
domain(), which fixes bothdomain()andhostname().domain()/hostname()now reject the 255-character example above.tests/test_domain.py+tests/test_hostname.py:88 passed.ruff check/ruff format --checkclean.