Skip to content

power: sequencing: pcie-m2: Add WCN6855 PCI ID and sort device ID table#1372

Open
WeiDeng-weiden wants to merge 2 commits into
qualcomm-linux:tech/bus/pci/allfrom
WeiDeng-weiden:tech/bus/pci/all
Open

power: sequencing: pcie-m2: Add WCN6855 PCI ID and sort device ID table#1372
WeiDeng-weiden wants to merge 2 commits into
qualcomm-linux:tech/bus/pci/allfrom
WeiDeng-weiden:tech/bus/pci/all

Conversation

@WeiDeng-weiden

Copy link
Copy Markdown

WCN6855 is a Qualcomm Wi-Fi/BT combo chip that uses PCI device ID 0x1103.
Add it to pwrseq_m2_pci_ids[] alongside the existing 0x1107 (WCN7850)
entry, so that the pwrseq-pcie-m2 driver creates a Bluetooth serdev device
for WCN6855 cards inserted into PCIe M.2 Key E connectors.
https://lore.kernel.org/r/20260608091702.3797437-2-wei.deng@oss.qualcomm.com

Sort the entries in pwrseq_m2_pci_ids[] by device ID in ascending order:
0x1103 (WCN6855) before 0x1107 (WCN7850).
https://lore.kernel.org/r/20260617143055.820096-1-wei.deng@oss.qualcomm.com

…uetooth

WCN6855 is a Qualcomm Wi-Fi/BT combo chip that uses PCI device ID
0x1103. Add it to pwrseq_m2_pci_ids[] alongside the existing 0x1107
(WCN7850) entry, so that the pwrseq-pcie-m2 driver creates a Bluetooth
serdev device for WCN6855 cards inserted into PCIe M.2 Key E connectors.

Link: https://patch.msgid.link/20260608091702.3797437-2-wei.deng@oss.qualcomm.com
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, krishnachaitanya-linux and meleung and removed request for a team June 17, 2026 15:26
@qlijarvis

Copy link
Copy Markdown

PR #1372 — validate-patch

PR: #1372

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — both patches include Link: tags pointing to lore.kernel.org/patch.msgid.link
  2. Lore link matches PR commits: N/A — network access restricted; cannot fetch upstream patches for byte-by-byte comparison
  3. Upstream patch status: Patch 1: FROMGIT (merged to maintainer tree); Patch 2: FROMLIST (under mailing list review)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Additional Notes:

  • Patch series is logically sound: patch 1 adds new PCI ID, patch 2 fixes ordering
  • Maintainer sign-off (Bartosz Golaszewski) present on patch 1 indicates acceptance
  • Both patches have subsystem maintainer review (Manivannan Sadhasivam)
  • Fixes tag in patch 2 correctly references the SHA from patch 1 in this series
  • Code changes are minimal, focused, and follow existing patterns in the file
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1372 - power: sequencing: pcie-m2: Add WCN6855 support and sort PCI IDs
Upstream commit: Patch 1: FROMGIT (merged to maintainer tree); Patch 2: FROMLIST (under review)
Verdict: ✅ PASS

Commit Message - Patch 1/2 (FROMGIT)

Check Status Note
Subject matches upstream Clean subject: "Add PCI ID 0x1103 for WCN6855 Bluetooth"
Body preserves rationale Explains WCN6855 chip, device ID, and driver behavior
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Wei Deng wei.deng@oss.qualcomm.com
Backport note (if applicable) N/A FROMGIT prefix indicates maintainer tree merge

Commit Message - Patch 2/2 (FROMLIST)

Check Status Note
Subject matches upstream Clear subject: "Sort PCI device IDs in ascending order"
Body preserves rationale Explains sorting rationale (0x1103 before 0x1107)
Fixes tag present/correct Fixes: 47e455d (correctly references patch 1)
Authorship preserved Wei Deng wei.deng@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST prefix indicates mailing list submission

Diff - Patch 1/2

File Status Notes
drivers/power/sequencing/pwrseq-pcie-m2.c Adds WCN6855 (0x1103) entry after WCN7850 (0x1107)

Diff - Patch 2/2

File Status Notes
drivers/power/sequencing/pwrseq-pcie-m2.c Reorders entries: 0x1103 before 0x1107 (ascending order)

Metadata Validation

Patch 1:

Patch 2:

Verdict

Merge as-is. Both patches follow kernel coding standards with proper commit messages, Link tags, review tags, and sign-offs. Patch 2 correctly fixes the ordering introduced by patch 1.

Final Summary

  1. Lore link present: Yes — both patches include Link: tags pointing to lore.kernel.org/patch.msgid.link
  2. Lore link matches PR commits: N/A — network access restricted; cannot fetch upstream patches for byte-by-byte comparison
  3. Upstream patch status: Patch 1: FROMGIT (merged to maintainer tree); Patch 2: FROMLIST (under mailing list review)
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Additional Notes:

  • Patch series is logically sound: patch 1 adds new PCI ID, patch 2 fixes ordering
  • Maintainer sign-off (Bartosz Golaszewski) present on patch 1 indicates acceptance
  • Both patches have subsystem maintainer review (Manivannan Sadhasivam)
  • Fixes tag in patch 2 correctly references the SHA from patch 1 in this series
  • Code changes are minimal, focused, and follow existing patterns in the file

@qlijarvis

Copy link
Copy Markdown

PR #1372 — checker-log-analyzer

PR: #1372
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27700182567

Checker Result Summary
Checker Result Summary
checkpatch Fixes tag title mismatch in commit 2/2
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check Passed (sparse tool not available, but no build errors)
check-uapi-headers ⏭️ No UAPI header changes
check-patch-compliance Both commits comply with FROMGIT/FROMLIST requirements
tag-check Proper FROMGIT/FROMLIST prefixes present
qcom-next-check FROMLIST:/FROMGIT: commits only

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1372 - power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27700182567

Checker Result Summary
checkpatch Fixes tag title mismatch in commit 2/2
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No devicetree changes
sparse-check Passed (sparse tool not available, but no build errors)
check-uapi-headers ⏭️ No UAPI header changes
check-patch-compliance Both commits comply with FROMGIT/FROMLIST requirements
tag-check Proper FROMGIT/FROMLIST prefixes present
qcom-next-check FROMLIST:/FROMGIT: commits only

❌ checkpatch

Root cause: The Fixes tag in commit eb178b5 references the wrong commit title - it uses the plain title without the "FROMGIT:" prefix.

Failure details:

WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: 47e455d1aa21 ("FROMGIT: power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth")'
#11: 
Fixes: 47e455d1aa21 ("power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth")

eb178b5f4e9f1f8917b656f1a62ff6b8bf850bbe total: 0 errors, 1 warnings, 0 checks, 12 lines checked

The Fixes tag currently reads:

Fixes: 47e455d1aa21 ("power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth")

But should be:

Fixes: 47e455d1aa21 ("FROMGIT: power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth")

Fix: Update the Fixes tag in commit 2/2 (eb178b5f4e9f) to include the "FROMGIT:" prefix in the referenced commit title. The title in the Fixes tag must exactly match the actual commit subject line.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 8dba9258929fce68a7b0d148c2a461ba2159f930..e741a837dcf7cd084f172b9af1af80220a0856fc

Or check a single commit:

git show eb178b5f4e9f | ./scripts/checkpatch.pl --strict -

Verdict

1 blocker to fix: The Fixes tag title must match the actual commit subject exactly, including the "FROMGIT:" prefix. This is a trivial fix - amend commit 2/2 to update the Fixes tag, then force-push the PR.

…g order

Sort the entries in pwrseq_m2_pci_ids[] by device ID in ascending order:
0x1103 (WCN6855) before 0x1107 (WCN7850).

Link: https://lore.kernel.org/r/20260617143055.820096-1-wei.deng@oss.qualcomm.com
Fixes: 47e455d ("FROMGIT: power: sequencing: pcie-m2: Add PCI ID 0x1103 for WCN6855 Bluetooth")
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team June 18, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants