Skip to content

PENDING: Shikra: Add display support for CQM and CQS targets#749

Open
naala-qcom wants to merge 4 commits into
qualcomm-linux:qcom-6.18.yfrom
naala-qcom:shikra/dt-fix
Open

PENDING: Shikra: Add display support for CQM and CQS targets#749
naala-qcom wants to merge 4 commits into
qualcomm-linux:qcom-6.18.yfrom
naala-qcom:shikra/dt-fix

Conversation

@naala-qcom

@naala-qcom naala-qcom commented Jun 21, 2026

Copy link
Copy Markdown

This patch series enables the display in shikra for CQM and CQS target.

Depends-On:
#748

Jira: https://jira-dc.qualcomm.com/jira/browse/QLIJIRA-133

CRs-Fixed: 4566067

@naala-qcom naala-qcom requested review from a team, Komal-Bajaj, aiquny and trsoni June 21, 2026 13:30
@qlijarvis

Copy link
Copy Markdown

PR #749 — validate-patch

PR: #749

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches not yet posted or awaiting upstream acceptance; no lore links in commit messages

  2. Lore link matches PR commits: N/A — no lore links to compare against

  3. Upstream patch status: Not upstream — all 4 commits carry PENDING: prefix indicating they are either not yet submitted or awaiting upstream review/acceptance

  4. PR present in qcom-next: Not checked — validation scope limited to patch correctness and upstream alignment per instructions

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #749 - Add MDSS display subsystem support for Shikra
Upstream commit: N/A (PENDING patches)
Verdict: ⚠️ PARTIAL

Commit 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Commit Message

Check Status Note
Subject matches upstream N/A PENDING prefix indicates not yet upstream
Body preserves rationale Clear description of hardware added and design choices
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved Author: Nabige Aala nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi Adds MDSS, DPU, DSI controller, and PHY nodes with proper bindings

Commit 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Commit Message

Check Status Note
Subject matches upstream N/A PENDING prefix indicates not yet upstream
Body preserves rationale Explains board enablement and regulator configuration
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved Author: Nabige Aala nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Enables MDSS, adds panel node, configures regulators and pinctrl

Commit 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Commit Message

Check Status Note
Subject matches upstream N/A PENDING prefix indicates not yet upstream
Body preserves rationale Explains why config is needed (used on Shikra CQM EVK)
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Author email changed: naala@qti.qualcomm.com (vs nabige.aala@oss.qualcomm.com in commits 1-2)
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/defconfig Adds CONFIG_DRM_PANEL_ILITEK_ILI7807S=m in alphabetical order

Commit 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Commit Message

Check Status Note
Subject matches upstream N/A PENDING prefix indicates not yet upstream
Body preserves rationale Brief but clear description of panel enablement
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Author email: naala@qti.qualcomm.com (inconsistent with commits 1-2)
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts Enables MDSS on CQS EVK, mirrors CQM EVK structure

Issues

  1. Author email inconsistency: Commits 1-2 use nabige.aala@oss.qualcomm.com while commits 3-4 use naala@qti.qualcomm.com. This should be consistent across the series.

  2. Missing Link tags: PENDING patches typically should include a Link: tag pointing to the lore.kernel.org discussion thread once posted upstream. These commits lack any Link tags.

  3. No upstream reference: The PENDING prefix indicates these patches are intended for upstream submission but haven't been posted yet, or are awaiting review. There's no indication of:

  4. Signed-off-by only: Kernel patches typically accumulate additional tags during review (Reviewed-by, Acked-by, Tested-by). The absence suggests these haven't been through upstream review yet.

Verdict

This is a PENDING patch series for new Shikra display hardware support. The patches are technically sound with proper DT bindings and logical structure, but show author email inconsistency and lack upstream submission evidence. Suitable for internal integration but should not be considered upstream-ready without addressing the authorship issue and completing upstream submission.

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches not yet posted or awaiting upstream acceptance; no lore links in commit messages

  2. Lore link matches PR commits: N/A — no lore links to compare against

  3. Upstream patch status: Not upstream — all 4 commits carry PENDING: prefix indicating they are either not yet submitted or awaiting upstream review/acceptance

  4. PR present in qcom-next: Not checked — validation scope limited to patch correctness and upstream alignment per instructions

@qlijarvis

Copy link
Copy Markdown

PR #749 — checker-log-analyzer

PR: #749
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27905934739

Checker Result Summary
Checker Result Summary
checkpatch All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Schema validation failure: iommus property too short
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance All 4 commits use PENDING: prefix (not UPSTREAM:/FROMLIST:)
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: commits present (expected for non-qcom-next branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #749 - PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27905934739

Checker Result Summary
checkpatch All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Schema validation failure: iommus property too short
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance All 4 commits use PENDING: prefix (not UPSTREAM:/FROMLIST:)
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: commits present (expected for non-qcom-next branches)

❌ dtb-check

Root cause: The iommus property in the MDSS node uses a 3-cell format <&apps_smmu 0x420 0x2>, but the qcom,qcm2290-mdss.yaml schema expects a 4-cell format per the SMMU binding.

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[41, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[41, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dtb: 
  display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[40, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#

Fix: Update the iommus property in arch/arm64/boot/dts/qcom/shikra.dtsi:3025 to use 4 cells instead of 3. Change:

-			iommus = <&apps_smmu 0x420 0x2>;
+			iommus = <&apps_smmu 0x420 0x0 0x2>;

The SMMU binding for ARM SMMUv2/v3 requires 4 cells: <phandle sid mask flags>. The missing cell is the mask field (typically 0x0 for exact SID match).

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) CHECK_DTBS=y qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: subject prefix, which does not comply with the required prefixes for upstream-bound patches.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix

Fix: Replace PENDING: with the appropriate prefix based on upstream status:

  • If patches are already merged upstream: use UPSTREAM: prefix
  • If patches are posted to mailing list but not yet merged: use FROMLIST: prefix
  • If patches are Qualcomm-internal only: use QCOM: prefix (if targeting qcom-next/qcom-next-staging)

For example:

FROMLIST: arm64: dts: qcom: shikra: Add MDSS display subsystem

Reproduce locally:

cd /path/to/kernel
git log --oneline acc3e66cc378..039d699c585c
# Verify each commit subject starts with UPSTREAM:, FROMLIST:, or QCOM:

Verdict

2 blockers must be fixed before merge:

  1. dtb-check failure: Add missing SMMU mask cell (0x0) to the iommus property in shikra.dtsi
  2. check-patch-compliance failure: Replace PENDING: prefix with UPSTREAM:, FROMLIST:, or QCOM: based on upstream status

After fixing these issues, re-run the kernel-checker CI to verify all checks pass.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ◻️ ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ◻️ ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ◻️

Nabige Aala and others added 4 commits June 23, 2026 19:17
Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper,
DPU display controller, DSI host controller, and 14nm DSI PHY.

Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific
compatible strings are used as the primary match with QCM2290 fallbacks
to reuse the existing driver support.

The dispcc clock inputs for the DSI byte and pixel PLLs are wired
from mdss_dsi0_phy.

Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
…7807s panel

Enable the Shikra MDSS display subsystem on the CQM EVK
board and add the ili7807s panel node. Pin pm4125_l5 to
1.232V with regulator-allow-set-load for DSI PHY PLL
stability.

Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module,
used on the Shikra CQM EVK board.

Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>
Enable the DLC0697 MIPI DSI display panel on the Shikra
CQS EVK.

Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team and ndechesne June 23, 2026 13:50
@qlijarvis

Copy link
Copy Markdown

PR #749 — validate-patch

PR: #749

Verdict Issues Detailed Report
⚠️ 4 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches prepared for upstream but not yet posted to lore.kernel.org

  2. Lore link matches PR commits: N/A — no lore link to compare against; these are pre-submission patches

  3. Upstream patch status: Not upstream — PENDING: prefix confirms these are queued for upstream submission but not yet posted to any mailing list

  4. PR present in qcom-next: Not checked — PENDING patches are typically staged in topic branches before upstream posting; qcom-next integration would occur after upstream acceptance

Recommendation: Fix the author email inconsistency (standardize on either nabige.aala@oss.qualcomm.com or naala@qti.qualcomm.com for all 4 patches), then the series will be ready for upstream submission to devicetree@vger.kernel.org and linux-arm-msm@vger.kernel.org.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #749 - Add MDSS display subsystem support for Shikra SoC
Upstream commit: N/A (PENDING: prefix indicates not yet posted upstream)
Verdict: ⚠️ PARTIAL - Authorship inconsistency must be fixed before upstream submission

Commit Message

Patch 1/4: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale Clear description of hardware and design choices
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New feature for Shikra SoC

Patch 2/4: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale Explains board enablement and regulator requirements
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved nabige.aala@oss.qualcomm.com
Backport note (if applicable) N/A New board support

Patch 3/4: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale Brief but adequate for defconfig change
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Email changed to naala@qti.qualcomm.com
Backport note (if applicable) N/A New driver enablement

Patch 4/4: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Check Status Note
Subject matches upstream N/A Not yet posted upstream
Body preserves rationale Brief but adequate for board enablement
Fixes tag present/correct N/A New feature, no Fixes tag needed
Authorship preserved ⚠️ Email changed to naala@qti.qualcomm.com
Backport note (if applicable) N/A New board support

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi Adds MDSS, DPU, DSI controller and PHY nodes; wires dispcc clocks correctly
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Enables display subsystem, adds panel node with proper supplies and pinctrl
arch/arm64/configs/defconfig Enables ILI7807S panel driver as module in alphabetical order
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts Mirrors CQM EVK display enablement for CQS board

Issues

Critical:

  • Authorship inconsistency: Patches 1-2 use nabige.aala@oss.qualcomm.com while patches 3-4 use naala@qti.qualcomm.com. For upstream submission, all patches in a series must use the same author email address. This must be corrected before posting to lore.kernel.org.

Minor observations:

  • Patch 4/4 commit body is very brief ("Enable the DLC0697 MIPI DSI display panel on the Shikra CQS EVK.") - could benefit from mentioning it mirrors the CQM EVK configuration or noting any differences
  • No Link: tags present (expected for PENDING patches not yet posted)
  • No Reviewed-by/Acked-by tags (expected for patches not yet reviewed upstream)

Verdict

Do not merge as-is. The authorship email inconsistency (patches 1-2 vs 3-4) must be fixed before upstream submission. All patches should use the same author email address throughout the series. Once corrected, the patches are technically sound and ready for upstream posting.

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patches prepared for upstream but not yet posted to lore.kernel.org

  2. Lore link matches PR commits: N/A — no lore link to compare against; these are pre-submission patches

  3. Upstream patch status: Not upstream — PENDING: prefix confirms these are queued for upstream submission but not yet posted to any mailing list

  4. PR present in qcom-next: Not checked — PENDING patches are typically staged in topic branches before upstream posting; qcom-next integration would occur after upstream acceptance

Recommendation: Fix the author email inconsistency (standardize on either nabige.aala@oss.qualcomm.com or naala@qti.qualcomm.com for all 4 patches), then the series will be ready for upstream submission to devicetree@vger.kernel.org and linux-arm-msm@vger.kernel.org.

@qlijarvis

Copy link
Copy Markdown

PR #749 — checker-log-analyzer

PR: #749
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28031207618

Checker Result Summary
Checker Result Summary
checkpatch All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Pre-existing warnings in shikra.dtsi:3577 (not introduced by this PR)
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance All 4 commits use "PENDING:" prefix instead of required UPSTREAM:/FROMLIST:/BACKPORT:
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: prefix used - requires FROMLIST:/UPSTREAM: for qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #749 - MDSS display subsystem for Shikra
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28031207618

Checker Result Summary
checkpatch All 4 commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Pre-existing warnings in shikra.dtsi:3577 (not introduced by this PR)
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI header changes
check-patch-compliance All 4 commits use "PENDING:" prefix instead of required UPSTREAM:/FROMLIST:/BACKPORT:
tag-check N/A Not applicable for this branch
qcom-next-check ⚠️ PENDING: prefix used - requires FROMLIST:/UPSTREAM: for qcom-next

❌ check-patch-compliance

Root cause: All four commits use the "PENDING:" prefix, which is not a recognized upstream compliance prefix.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix

Fix: Replace "PENDING:" with one of the required prefixes:

  • UPSTREAM: if the patch has been merged into Linus's tree
  • FROMLIST: if the patch has been posted to a mailing list but not yet merged
  • BACKPORT: if backporting from a newer kernel version
  • CHROMIUM: for ChromeOS-specific patches
  • ANDROID: for Android-specific patches

For new development work posted to mailing lists, use FROMLIST:

# Reword all 4 commits:
git rebase -i HEAD~4
# Change "pick" to "reword" for all 4 commits
# Then replace "PENDING:" with "FROMLIST:" in each commit message

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>

❌ dtb-check

Root cause: Pre-existing devicetree warnings in arch/arm64/boot/dts/qcom/shikra.dtsi:3577 for interrupt-cells property size validation.

Failure details:

../arch/arm64/boot/dts/qcom/shikra.dtsi:3577.4-27: Warning (interrupts_property): /soc@0/pcie@45e8000:#interrupt-cells: size is (108), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3577.4-27: Warning (interrupts_property): /soc@0/mmc@4784000:#interrupt-cells: size is (24), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3577.4-27: Warning (interrupts_property): /soc@0/ethernet@5d00000:#interrupt-cells: size is (12), expected multiple of 16
../arch/arm64/boot/dts/qcom/shikra.dtsi:3577.4-27: Warning (interrupts_property): /soc@0/ethernet@5d20000:#interrupt-cells: size is (12), expected multiple of 16

Analysis: These warnings appear to be pre-existing issues in the shikra.dtsi base file, not introduced by this PR. The PR adds MDSS display subsystem nodes (around line 3004-3207 based on the patch), while the warnings reference line 3577 which is likely in a different section (PCIe, MMC, Ethernet nodes). The dtb-check script compares errors before and after the PR, and these warnings appear in both the base and head builds, indicating they were already present.

Fix: These are pre-existing warnings that should be fixed in a separate cleanup PR. They do not block this PR since they were not introduced by these changes. However, if you want to address them:

  1. Investigate the interrupt-cells definitions at line 3577 in shikra.dtsi
  2. Ensure interrupt specifiers for PCIe, MMC, and Ethernet nodes have sizes that are multiples of 16
  3. Submit a separate fix PR for the base shikra.dtsi issues

Reproduce locally:

cd /path/to/kernel
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqm-evk.dtb

Verdict

2 blockers to fix:

  1. BLOCKER: Replace "PENDING:" prefix with "FROMLIST:" (or appropriate prefix) in all 4 commit messages
  2. NON-BLOCKER: dtb-check warnings are pre-existing and not introduced by this PR - can be addressed in a separate cleanup PR

The check-patch-compliance failure is a hard blocker that must be fixed before merge. The dtb-check warnings are pre-existing issues that should be tracked separately but do not block this PR.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants