PENDING: arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count

[ayaan-anwar]

Commit bf449f3 ("arm64: dts: qcom: shikra: switch to interrupt-cells 4 to add PPI partitions") bumped the GIC node to interrupt-cells = <4> and updated all existing interrupt specifiers accordingly. The ethernet nodes, raised on top of the older version of the patch series are left with a 3-cell specifier against a 4-cell GIC.

At boot, of_irq_parse_one() reads intsize=4 from the GIC, then of_property_read_u32_index() attempts to read the 4th cell of a 3-cell property and returns -EOVERFLOW, causing
platform_get_irq_byname("macirq") to fail with -ENXIO:

qcom-ethqos 5d00000.ethernet: error -ENXIO: IRQ macirq not found
qcom-ethqos 5d00000.ethernet: error -ENXIO: Failed to get platform
resources

Add the missing 4th cell to both ethernet nodes. This will be posted in V2 of the ethernet series.
The QLI mainline PR has been updated with the fix (qualcomm-linux/kernel-topics#1318).
Using PENDING tag for this branch as its a minor change which will be included in the next iteration of the series.

Fixes: a1b735d ("arm64: dts: qcom: shikra: Add ethernet nodes")
CRs-Fixed: 4570559

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #757 — validate-patch

PR: #757

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

1. Lore link present: No — PENDING: prefix; patch will be posted in V2 of ethernet series per commit message
2. Lore link matches PR commits: N/A — no lore link to compare against (not yet posted)
3. Upstream patch status: Not upstream — local integration fix; author states it will be included in V2 of ethernet series
4. PR present in qcom-next: Not checked — PENDING commit, not yet posted upstream

Additional Context:
This patch fixes a probe failure caused by an interrupt specifier cell count mismatch. The GIC was bumped to interrupt-cells=4 in commit bf449f3, but ethernet nodes (added via FROMLIST) still used 3-cell specifiers. The fix correctly adds the 4th cell (PPI partition, value 0) to both ethernet nodes, resolving the -ENXIO error at probe time.

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #757 - PENDING: arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count
Upstream commit: N/A (PENDING - will be posted in V2 of ethernet series)
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Not yet posted; subject follows kernel style
Body preserves rationale	✅	Excellent root-cause analysis with error logs
Fixes tag present/correct	✅	References FROMLIST commit a1b735d
Authorship preserved	✅	Mohd Ayaan Anwar mohd.anwar@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport; local integration fix

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/shikra.dtsi	✅	Adds missing 4th cell (0) to two ethernet interrupt specifiers

Verdict

Merge as-is. This is a correct integration fix for a local mismatch between GIC interrupt-cells=4 and 3-cell ethernet interrupt specifiers, with excellent commit message documentation.

Final Summary

1. Lore link present: No — PENDING: prefix; patch will be posted in V2 of ethernet series per commit message
2. Lore link matches PR commits: N/A — no lore link to compare against (not yet posted)
3. Upstream patch status: Not upstream — local integration fix; author states it will be included in V2 of ethernet series
4. PR present in qcom-next: Not checked — PENDING commit, not yet posted upstream

Additional Context:
This patch fixes a probe failure caused by an interrupt specifier cell count mismatch. The GIC was bumped to interrupt-cells=4 in commit bf449f3, but ethernet nodes (added via FROMLIST) still used 3-cell specifiers. The fix correctly adds the 4th cell (PPI partition, value 0) to both ethernet nodes, resolving the -ENXIO error at probe time.

[qlijarvis]

PR #757 — checker-log-analyzer

PR: #757
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27982557389

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID + incorrect Fixes tag format
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	Passed
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: "PENDING:" not allowed
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable (PENDING prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #757 - PENDING: arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27982557389

Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID + incorrect Fixes tag format
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	Passed
sparse-check	⏭️	Skipped (no C code changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Subject prefix violation: "PENDING:" not allowed
tag-check	N/A	Not applicable for this branch
qcom-next-check	N/A	Not applicable (PENDING prefix)

---

❌ checkpatch

Root cause: Two checkpatch warnings triggered by commit message formatting issues.

Failure details:

WARNING: Unknown commit id 'bf449f3bcc81', maybe rebased or not pulled?
#7: 
Commit bf449f3bcc81 ("arm64: dts: qcom: shikra: switch to

WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1> ("<title line>")' - ie: 'Fixes: a1b735d91845 ("FROMLIST: arm64: dts: qcom: shikra: Add ethernet nodes")'
#26: 
Fixes: a1b735d91845 ("arm64: dts: qcom: shikra: Add ethernet nodes")

Issues identified:

1. Unknown commit reference: The commit message references bf449f3bcc81 which is not present in the kernel tree being checked. This commit is likely from a different branch or hasn't been merged yet.

2. Incorrect Fixes tag format: The Fixes tag uses only 12 characters of the SHA-1 hash. Checkpatch expects at least 12 characters but the warning suggests the format might need adjustment. However, looking at the actual tag, it appears to be correctly formatted with 12 characters. The warning may be a false positive or the commit a1b735d91845 might have the "FROMLIST:" prefix in its subject which could be causing the parser confusion.

Fix:

1. For the unknown commit warning: This is informational and can be ignored if bf449f3bcc81 is a valid commit in the context where this patch will be applied. If submitting upstream, ensure the referenced commit exists in the target tree.

2. For the Fixes tag: The format appears correct (12-char SHA + title). This warning can likely be ignored, but verify the commit a1b735d91845 exists in the target branch.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git c14585bb7b43b15841417db40e4d43ddbd77a247..ce5ab731f40432f4b570a2c2d7319f5f5ececabb

---

❌ check-patch-compliance

Root cause: Subject line starts with "PENDING:" prefix which violates patch compliance rules.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count
Commit summary does not start with a required prefix

Issue identified:

The check-patch-compliance checker enforces that commit subjects must start with approved prefixes (typically UPSTREAM:, FROMLIST:, BACKPORT:, or subsystem-specific prefixes). The PENDING: prefix is not in the allowed list.

Fix:

Remove the PENDING: prefix from the commit subject. Since this patch fixes an issue in a FROMLIST: commit, the appropriate prefix would be:

FROMLIST: arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count

Or if this is a local fix that will be posted upstream:

arm64: dts: qcom: shikra: fix ethernet interrupt specifier cell count

Then add a note in the commit message body indicating this will be included in v2 of the ethernet series (as already mentioned in the current commit message).

Reproduce locally:

bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base c14585bb7b43b15841417db40e4d43ddbd77a247 --head ce5ab731f40432f4b570a2c2d7319f5f5ececabb

---

Verdict

2 blockers must be fixed before merge:

1. Critical: Remove PENDING: prefix from subject line (check-patch-compliance failure)
2. Minor: Address checkpatch warnings (can be ignored if commits are valid in target context)

Recommended action: Update the commit message to use an approved prefix (FROMLIST: or remove prefix entirely) and optionally verify the referenced commits exist in the target branch to clear checkpatch warnings.

[ayaan-anwar]

Closing this as the fix is already provided by #751