Upgrade dependencies#6546
Conversation
| serde_json = { workspace = true } | ||
| tantivy = { workspace = true } | ||
| time = { workspace = true } | ||
| time-fmt = "0.3.8" |
There was a problem hiding this comment.
why is this not in the workspace-level Cargo.toml?
There was a problem hiding this comment.
I think some rare deps that are only used in sub packages we haven't moved to workspace level. Let me clean this up.
guilload
force-pushed
the
guilload/upgrade-deps
branch
from
09e3bd3 to
a1fcb64
Compare
guilload
force-pushed
the
guilload/upgrade-deps
branch
from
a1fcb64 to
b9a4f58
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9a4f58104
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| serde_json_borrow = "0.9" | ||
| serde_qs = { version = "0.15" } | ||
| serde_with = "3.20" | ||
| serde_qs = { version = "1.1" } |
There was a problem hiding this comment.
When an Elasticsearch bulk request uses a bare ?refresh parameter (no =), ElasticBulkOptions is supposed to treat it as ElasticRefresh::True for compatibility, and the existing test covers serde_qs::from_str::<ElasticBulkOptions>("refresh"). With serde_qs 1.1, that bare parameter is deserialized as a no-value/unit for enum fields instead of the empty-string alias, so this request now fails query parsing and returns 400 rather than forcing a refresh; please either adapt the refresh parser or avoid this serde_qs behavior change.
Useful? React with 👍 / 👎.
2 participants
No description provided.