Skip to content

Adjust libs to new Common Folder#337

Closed
nxtum wants to merge 6 commits into
rdkcentral:masterfrom
nxtum:ThunderCommonFolder
Closed

Adjust libs to new Common Folder#337
nxtum wants to merge 6 commits into
rdkcentral:masterfrom
nxtum:ThunderCommonFolder

Conversation

@nxtum

@nxtum nxtum commented May 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 27, 2026 08:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates client libraries to use Thunder’s new Common headers/package (moving Types.h from plugins to common) and wires the corresponding CMake dependencies so targets can compile against the new layout.

Changes:

  • Replace #include <plugins/Types.h> with #include <common/Types.h> where applicable.
  • Add ${NAMESPACE}Common find_package(...) and link ${NAMESPACE}Common::${NAMESPACE}Common for updated components.
  • Update the compositorclient test plugin to include/link Thunder Common.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Source/playerinfo/PlayerInfo.cpp Switch Types.h include to common/Types.h.
Source/playerinfo/CMakeLists.txt Add Thunder Common package + link dependency.
Source/displayinfo/DisplayInfo.cpp Switch Types.h include to common/Types.h.
Source/displayinfo/CMakeLists.txt Add Thunder Common package + link dependency.
Source/deviceinfo/DeviceInfo.cpp Add common/Types.h include (but missing corresponding CMake dependency update).
Source/cryptography/Cryptography.cpp Switch Types.h include to common/Types.h.
Source/cryptography/CMakeLists.txt Add Thunder Common package + link dependency (incl. software variant).
Source/compositorclient/test/client-renderer/plugin/Module.h Include Thunder Common header umbrella.
Source/compositorclient/test/client-renderer/plugin/CMakeLists.txt Add Thunder Common package + link dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Source/deviceinfo/DeviceInfo.cpp
@nxtum nxtum requested a review from sebaszm May 27, 2026 09:42
Copilot AI review requested due to automatic review settings May 29, 2026 07:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@nxtum nxtum closed this Jun 15, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants