Skip to content

fix: restore browser targets#973

Open
QDyanbing wants to merge 2 commits into
react-component:masterfrom
QDyanbing:fix-father-plugin-targets
Open

fix: restore browser targets#973
QDyanbing wants to merge 2 commits into
react-component:masterfrom
QDyanbing:fix-father-plugin-targets

Conversation

@QDyanbing

Copy link
Copy Markdown
Contributor

Summary

  • Avoid rc package deep imports for the new rc father plugin checks.
  • Restore the browser compile target to the previous Father default with targets: { ie: 11 }.
  • Prevent modern syntax from leaking into the published es and lib output for older webpack parsers.

Root Cause

@rc-component/father-plugin@2.2.0 defaults targets to { chrome: 85 }, which is newer than the previous Father browser default. Without an explicit override, the published output can keep syntax that older webpack parsers cannot parse.

Verification

  • npm run compile
  • acorn@6 parses all generated es and lib JavaScript files after the fix
  • npm test -- --runInBand

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@QDyanbing, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 22 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af41b6cd-ce65-494a-8604-63c130f73177

📥 Commits

Reviewing files that changed from the base of the PR and between 9a39561 and f464c0c.

📒 Files selected for processing (28)
  • .fatherrc.js
  • README.md
  • package.json
  • src/PickerInput/RangePicker.tsx
  • src/PickerInput/Selector/Input.tsx
  • src/PickerInput/Selector/hooks/useClearIcon.tsx
  • src/PickerInput/Selector/hooks/useInputProps.ts
  • src/PickerInput/SinglePicker.tsx
  • src/PickerInput/hooks/useDelayState.ts
  • src/PickerInput/hooks/useLockEffect.ts
  • src/PickerInput/hooks/usePresets.ts
  • src/PickerInput/hooks/useRangePickerValue.ts
  • src/PickerInput/hooks/useRangeValue.ts
  • src/PickerPanel/TimePanel/TimePanelBody/TimeColumn.tsx
  • src/PickerPanel/TimePanel/TimePanelBody/useScrollTo.ts
  • src/PickerPanel/index.tsx
  • src/PickerTrigger/index.tsx
  • src/generate/moment.ts
  • src/utils/warnUtil.ts
  • tests/disabledTime.spec.tsx
  • tests/keyboard.spec.tsx
  • tests/loop.spec.tsx
  • tests/multiple.spec.tsx
  • tests/new-range.spec.tsx
  • tests/panel.spec.tsx
  • tests/picker.spec.tsx
  • tests/range.spec.tsx
  • tests/time.spec.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions for @rc-component/util and @rc-component/father-plugin in package.json, targets IE 11 in .fatherrc.js, and corrects the locale import paths in README.md. It also refactors numerous imports across source and test files to import directly from the package roots of @rc-component/util and @rc-component/trigger instead of using deep paths. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.81%. Comparing base (0087213) to head (f464c0c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          65       65           
  Lines        2695     2695           
  Branches      744      724   -20     
=======================================
  Hits         2663     2663           
  Misses         29       29           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .fatherrc.js
plugins: ['@rc-component/father-plugin'],
targets: {
ie: 11,
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个太低了,antd v6 不是这个 target。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants