Use cryptography-kotlin in the app itself also#3073
Open
Luna712 wants to merge 1 commit into
Open
Conversation
It is more type safe and IMO cleaner code.
Contributor
Author
|
Note: I have had this patch ready to go for quite awhile, but wanted to wait for the one that added the kotlinx-io dependency so I could use it. I can't fully remember just how much of this was actually fully tested so there may indeed be some potential issue with it. |
Luna712
commented
Jul 15, 2026
| // Disables ssl check | ||
| val sslContext: SSLContext = SSLContext.getInstance("TLS") | ||
| sslContext.init(null, arrayOf(SSLTrustManager()), SecureRandom()) | ||
| sslContext.init(null, arrayOf(SSLTrustManager()), null) |
Contributor
Author
There was a problem hiding this comment.
Note: this was just removed because it has the same behavior as far as I could tell, null just uses a default SecureRandom and we don't need to pass it so I thought we should just let it handle it there to remove all usage of SecureRandom. But it can be changed if really wanted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is more type safe and IMO cleaner code.