Library: use api for some dependencies#3076
Open
Luna712 wants to merge 1 commit into
Open
Conversation
I am not 100% sure if we should. This will avoid extensions having to manually add them also allowing us to make sure we standardize versions, but it can also slow the build down according to https://docs.gradle.org/current/userguide/performance.html#use_implementation_for_internal_dependencies
Contributor
Author
|
The common convention for libraries does seem to be to use api() so that is what I do think we should do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not 100% sure if we should. This will avoid extensions having to manually add them also allowing us to make sure we standardize versions, but it can also slow the build down according to https://docs.gradle.org/current/userguide/performance.html#use_implementation_for_internal_dependencies