Skip to content

[PHPUnit120] Add BareVarToStubIntersectionRector#690

Merged
TomasVotruba merged 2 commits into
mainfrom
add-bare-var-to-stub-intersection-rector
Jun 29, 2026
Merged

[PHPUnit120] Add BareVarToStubIntersectionRector#690
TomasVotruba merged 2 commits into
mainfrom
add-bare-var-to-stub-intersection-rector

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Jun 29, 2026

Copy link
Copy Markdown
Member

Similar to #689 (MockObjectVarToStubRector), adds a complementary rule.

When a property is converted to a Stub native type but its @var docblock holds only the bare mocked-class type, this rule adds the &Stub intersection.

 /**
- * @var FormBuilderInterface
+ * @var FormBuilderInterface&Stub
  */
 private \PHPUnit\Framework\MockObject\Stub $formBuilder;

Scope:

  • only inside PHPUnit TestCase
  • only properties already typed as native Stub
  • only a bare single-class @var (skips union/intersection, and Stub/MockObject short names)

Registered in PHPUNIT_MOCK_TO_STUB and PHPUNIT_CODE_QUALITY sets. Complements MockObjectVarToStubRector, which deliberately skips this bare-var case.

@TomasVotruba TomasVotruba merged commit 7d86878 into main Jun 29, 2026
8 checks passed
@TomasVotruba TomasVotruba deleted the add-bare-var-to-stub-intersection-rector branch June 29, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant