[TypeDeclaration] Add AddClosureParamTypeFromVariableCallRector#8142
Merged
Conversation
Infer a closure param's object type from the argument the assigned closure variable is invoked with, e.g. $cb($formView) where $formView is a FormView adds a FormView type hint to the closure param. Only concrete object types are added; scalar/array/conflicting args are skipped.
…mDimFetchRector Infer the closure param object type before the array-dim-fetch rule runs, so a typed param is already present and the array fallback is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complements #8141. Where #8141 stops the wrong
arraytype on recursive closures walking anArrayAccesstree, this new rule adds the correct object type from the call site.What it does
When a closure is assigned to a variable and that variable is invoked with a concrete object argument, the object type is added to the matching closure param:
Real-world case (Symfony
FormView):Scope (conservative)
StrictArrayParamDimFetchRector).Covered by fixtures: object param added, recursive FormView, skip already-typed, skip scalar arg, skip conflicting types.