Skip to content

docs(batch): document tags support#200

Closed
cpenned wants to merge 3 commits into
mainfrom
cursor/batch-schedule-tags-attachments-1c02
Closed

docs(batch): document tags support#200
cpenned wants to merge 3 commits into
mainfrom
cursor/batch-schedule-tags-attachments-1c02

Conversation

@cpenned

@cpenned cpenned commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

The batch send API supports tags per email. This PR documents that support in the Ruby SDK.

Changes

  • Document that each batch email supports tags
  • Add a spec verifying tags are serialized in the request body

Notes

No runtime code changes were required — Resend::Batch.send forwards the params array as JSON via Resend::Request.

Open in Web Open in Cursor 

Summary by cubic

Documents per‑email tags support in Resend::Batch.send, noting each email accepts the same fields as Resend::Emails.send. Adds a spec to verify tags are serialized in the request body; no runtime changes.

Written for commit b4884ef. Summary will update on new commits.

Review in cubic

Each batch email accepts the same fields as Resend::Emails.send,
including scheduled_at, tags, and attachments. Add a spec that
verifies these fields are passed through in the request body.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Jul 10, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Documents per-email fields (scheduled_at, tags, attachments) in batch.send method and adds a spec to verify serialization. No runtime code changes.

Re-trigger cubic

Batch emails support tags per email. scheduled_at and attachments
are not supported in batch and are documented as such.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>
@cursor cursor Bot changed the title docs(batch): document schedule, tags, and attachments support docs(batch): document tags support Jul 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread lib/resend/batch.rb Outdated
@cubic-dev-ai
cubic-dev-ai Bot dismissed their stale review July 13, 2026 16:20

Dismissed because Cubic found issues in a newer review.

Co-authored-by: cpenned <cpenned@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="lib/resend/batch.rb">

<violation number="1" location="lib/resend/batch.rb:10">
P2: The docstring says "Each hash accepts the same fields as {Resend::Emails.send}, including:" but according to the Resend API docs, `attachments` and `scheduled_at` are explicitly **not supported** on the batch endpoint (`POST /emails/batch`). Saying "same fields" without the exception is misleading — users who read this will pass `attachments` or `scheduled_at` parameters and silently fail or get an error at runtime. The previous version (before this PR) had no field-level documentation, which was incomplete but not actively misleading. Recommend restoring the caveat that `attachments` and `scheduled_at` are not supported in batch, e.g. "Each hash accepts the same fields as {Resend::Emails.send}, including +tags+ per email, except +scheduled_at+ and +attachments+ which are not supported in batch."</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

Comment thread lib/resend/batch.rb
#
# @param params [Array<Hash>] Array of email parameters (max 100 emails)
# Each email in +params+ accepts the same fields as {Resend::Emails.send},
# including +tags+ per email.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The docstring says "Each hash accepts the same fields as {Resend::Emails.send}, including:" but according to the Resend API docs, attachments and scheduled_at are explicitly not supported on the batch endpoint (POST /emails/batch). Saying "same fields" without the exception is misleading — users who read this will pass attachments or scheduled_at parameters and silently fail or get an error at runtime. The previous version (before this PR) had no field-level documentation, which was incomplete but not actively misleading. Recommend restoring the caveat that attachments and scheduled_at are not supported in batch, e.g. "Each hash accepts the same fields as {Resend::Emails.send}, including +tags+ per email, except +scheduled_at+ and +attachments+ which are not supported in batch."

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At lib/resend/batch.rb, line 10:

<comment>The docstring says "Each hash accepts the same fields as {Resend::Emails.send}, including:" but according to the Resend API docs, `attachments` and `scheduled_at` are explicitly **not supported** on the batch endpoint (`POST /emails/batch`). Saying "same fields" without the exception is misleading — users who read this will pass `attachments` or `scheduled_at` parameters and silently fail or get an error at runtime. The previous version (before this PR) had no field-level documentation, which was incomplete but not actively misleading. Recommend restoring the caveat that `attachments` and `scheduled_at` are not supported in batch, e.g. "Each hash accepts the same fields as {Resend::Emails.send}, including +tags+ per email, except +scheduled_at+ and +attachments+ which are not supported in batch."</comment>

<file context>
@@ -7,11 +7,10 @@ class << self
       # Each email in +params+ accepts the same fields as {Resend::Emails.send},
-      # except +scheduled_at+ and +attachments+, which are not supported in batch.
-      # +tags+ are supported per email.
+      # including +tags+ per email.
       #
       # @param params [Array<Hash>] Array of email parameters (max 100 emails).
</file context>

@cpenned cpenned closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants