fix(admin): stabilize pool status and disk indexes#231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: Fixes #229 and Fixes #230. Background: pool status behind HAProxy could return node-dependent pool lists, and cluster info displayed all disk locations as pool:0 set:0 disk:0. Root cause: no-target pool status used the node-local pool list endpoint, and disk location indexes from cluster info used snake_case fields that were not accepted by the client model. Solution: use cluster info pool metrics for no-target pool status, preserve targeted pool status and pool list routes, and accept snake_case disk location indexes from the server response. Validation: cargo fmt --all; cargo fmt --all --check; cargo clippy --workspace -- -D warnings; cargo test --workspace.