Skip to content

Guard against null parameter fields in OpenAPI operation parsing #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcruzdev wants to merge 5 commits into
base: main
Choose a base branch
from
+6 −5
Open

Guard against null parameter fields in OpenAPI operation parsing #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83014f9
Guard against null parameter fields in OpenAPI operation parsing
mcruzdev Jun 11, 2026
88a0d2a
Guard operation.parameters from NPE
mcruzdev Jun 11, 2026
9f269c9
Apply pull request suggestions
mcruzdev Jun 12, 2026
b27d743
Compare enum with == operator
mcruzdev Jun 12, 2026
91fc24f
Apply @fjtirado suggestions
mcruzdev Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...enapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OperationDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ List<ParameterDefinition> getParameters() {
List<ParameterDefinition> paramDefinitions = new ArrayList<>();
if (operation.hasParameters()) {
for (UnifiedOpenAPI.Parameter parameter : operation.parameters()) {
if (parameter.in().equals("body")) {
if ("body".equals(parameter.in())) {
continue; // body parameters are handled separately
}

Expand All @@ -70,13 +70,14 @@ List<ParameterDefinition> getParameters() {
}
}

if (openAPI.swaggerVersion().equals(UnifiedOpenAPI.SwaggerVersion.SWAGGER_V2)) {
if (openAPI.swaggerVersion() == UnifiedOpenAPI.SwaggerVersion.SWAGGER_V2
&& operation.parameters() != null) {

@fjtirado fjtirado Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&& operation.parameters() != null) {
&& operation.hasParameters()) {

operation.parameters().stream()
Comment on lines +73 to 75
.filter(p -> p.in().equals("body"))
.filter(p -> "body".equals(p.in()))
.forEach(
p -> {
UnifiedOpenAPI.Schema schema = p.schema();
if (schema.hasRef()) {
if (schema != null && schema.hasRef()) {
String ref = schema.ref();
schema = openAPI.resolveSchema(ref);
}
Comment thread
fjtirado marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/UnifiedOpenAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public boolean hasRequestBody() {
}
}

public record Parameter(String name, String in, Boolean required, Schema schema) {}
public record Parameter(String name, String in, boolean required, Schema schema) {}
Comment thread
fjtirado marked this conversation as resolved.

public record RequestBody(Content content) {}

Expand Down
Loading