Calculate basic alignment score for word pairs from the sentence_score#316
Open
pmachapman wants to merge 1 commit into
Open
Calculate basic alignment score for word pairs from the sentence_score#316pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
Enkidu93
approved these changes
Jun 18, 2026
Enkidu93
left a comment
Collaborator
There was a problem hiding this comment.
That's too bad that they don't expose the per-word scores - I didn't realize that, sorry. I leave it to Damien whether he's comfortable with this workaround until eflomal is properly integrated.
@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the average of the forward and reverse sentence_score from eflomal, places it between 0 and 1.0, and saves it for each word pair score.
Not accurate at all as a per-word pair score, but without using a different aligner than eflomal, I am not too sure how else to get an accurate word alignment score.
This change is