Skip to content

Fix incorrect chapter numbers returned from UsfmStructureExtractor#430

Open
pmachapman wants to merge 1 commit into
masterfrom
fix_get_chapters
Open

Fix incorrect chapter numbers returned from UsfmStructureExtractor#430
pmachapman wants to merge 1 commit into
masterfrom
fix_get_chapters

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Port of sillsdev/machine.py#315

Original issue: sillsdev/machine.py#308


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 18, 2026 01:51
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.18%. Comparing base (c1bd2cc) to head (3b7d2a7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         440      440           
  Lines       36882    36882           
  Branches     5075     5075           
=======================================
  Hits        26991    26991           
  Misses       8778     8778           
  Partials     1113     1113           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants