-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(webhooks): stop dropping pre-deployment verification response on shared paths #5579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -186,6 +186,10 @@ async function handleWebhookPost( | |
| continue | ||
| } | ||
|
|
||
| if (dispatchResult.outcome === 'verified') { | ||
| return dispatchResult.response | ||
| } | ||
|
Comment on lines
+189
to
+191
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a block-missing webhook on a shared path belongs to a provider with pending verification enabled, this branch returns 200 before later webhooks on the same path are checked. Since the new |
||
|
|
||
| if (dispatchResult.outcome === 'failed' || dispatchResult.reason === 'block-missing') { | ||
| if (webhooksForPath.length > 1) { | ||
| logger.warn( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified return skips queued sibling
Medium Severity
On a shared path, when an earlier webhook already produced a queued success response, a later webhook with
outcomeverifiedstill short-circuits the loop and returns the URL-verification body. The caller may get a verification 200 even though another webhook on the path already accepted the delivery.Reviewed by Cursor Bugbot for commit f95c224. Configure here.