feat(chat): soft-delete sidebar chats with restore from Recently Deleted by waleedlatif1 · Pull Request #5830 · simstudioai/sim

waleedlatif1 · 2026-07-22T00:48:07Z

Summary

Deleting a chat from the sidebar is now a soft delete: sets copilot_chats.deleted_at instead of dropping the row, so chats show up in Settings → Recently Deleted and can be restored (Marcus's archive request)
New POST /api/mothership/chats/[chatId]/restore route + contract, owner-scoped like delete; list endpoint gains scope=active|archived
Recently Deleted gets a Chats tab; chat restore is not gated on workspace edit permission since chats are per-user (any member can delete/restore their own)
Deleted chats are excluded everywhere: lifecycle access helpers (shared ownedLiveChatWhere predicate), fork, legacy copilot chat lists, chat resources routes, copilot VFS tasks listing
Soft-deleted chats join the retention purge in cleanup-soft-deletes via the existing prepareChatCleanup teardown, matching every other Recently Deleted resource
Migration 0264: nullable deleted_at + partial index (user_id, workspace_id) WHERE deleted_at IS NOT NULL, built CONCURRENTLY; expand-only, backward-compatible with the deployed app
Delete-confirmation copy updated: chats are archived and restorable, not "permanently removed"

Type of Change

New feature

Testing

Unit tests updated/added for the soft-delete DELETE, scope-filtered list, and lifecycle exclusion; migration applied and verified against a local Postgres; full affected suites green (496 tests)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-22T00:48:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 22, 2026 2:49am

cursor · 2026-07-22T00:48:18Z

PR Summary

Medium Risk
Touches chat lifecycle, retention cleanup, and many list/mutation paths; race-safe cleanup reduces data-loss risk on restore, but behavior changes are broad across copilot/mothership APIs.

Overview
Sidebar mothership chats are soft-deleted (copilot_chats.deleted_at) instead of hard-deleted, so they appear in Settings → Recently Deleted and can be brought back. Restore is exposed as POST /api/mothership/chats/[chatId]/restore; listing adds scope=active|archived, with React Query keys split so active and archived lists stay in sync on delete/restore.

Active reads and mutations now require deleted_at IS NULL (shared ownedLiveChatWhere, list queries, resource routes, fork). The legacy /api/copilot/chat/delete path returns 400 for mothership chats so it cannot bypass the soft-delete flow.

Recently Deleted gains a Chats tab and useRestoreMothershipChat; chat restore is allowed without workspace edit permission (per-user ownership). Delete modal copy treats chats as archivable/restorable like workflows.

Retention jobs hard-delete expired soft-deleted chats (and fold them into prepareChatCleanup); cleanup re-checks row existence / cutoffs so restores mid-job do not purge S3 or copilot backend data. Migration 0264 adds deleted_at and a partial index for archived listings.

^{Reviewed by Cursor Bugbot for commit 742ad5b. Configure here.}

greptile-apps · 2026-07-22T00:50:54Z

Greptile Summary

This PR adds soft deletion and restoration for sidebar chats. The main changes are:

Archives deleted chats and lists them under Recently Deleted.
Adds owner-scoped chat restore and active-versus-archived list APIs.
Excludes archived chats from active chat operations and related data surfaces.
Permanently purges expired archived chats through retention cleanup.
Adds the database column, partial index, UI, hooks, contracts, and tests.

Confidence Score: 5/5

This looks safe to merge.

Permanent deletion rechecks the retention condition, so a restored chat or workflow survives a concurrent cleanup.
External chat cleanup skips rows that still exist after the database deletion phase.
Restoring a workspace chat requires both ownership and current workspace access.
No blocking issues remain in the changed code.

Important Files Changed

Filename	Overview
apps/sim/background/cleanup-soft-deletes.ts	Adds expired-chat cleanup and rechecks chat and workflow eligibility before permanent deletion.
apps/sim/lib/cleanup/chat-cleanup.ts	Rechecks chat survival before removing backend data and attributed files.
apps/sim/background/cleanup-tasks.ts	Rechecks chat age during retention deletion and relies on chat-row cascades for owned child records.
apps/sim/app/api/mothership/chats/[chatId]/restore/route.ts	Adds owner-scoped restoration with current workspace access validation and refreshed activity timestamps.
apps/sim/hooks/queries/mothership-chats.ts	Adds scoped chat-list queries, restoration, and cache invalidation for active and archived lists.
packages/db/migrations/0264_fat_ikaris.sql	Adds nullable chat deletion timestamps and an index for archived-chat lookup.

_{Reviews (10): Last reviewed commit: "fix(cleanup): recheck workflow archive c..." | Re-trigger Greptile}

…rchived-list invalidation

waleedlatif1 · 2026-07-22T01:00:06Z

@greptile

waleedlatif1 · 2026-07-22T01:00:07Z

@cursor review

…tion

waleedlatif1 · 2026-07-22T01:10:16Z

@greptile

waleedlatif1 · 2026-07-22T01:10:17Z

@cursor review

…k cleanup

waleedlatif1 · 2026-07-22T01:17:29Z

@greptile

waleedlatif1 · 2026-07-22T01:17:30Z

@cursor review

…scade covers it

waleedlatif1 · 2026-07-22T01:24:09Z

@greptile

waleedlatif1 · 2026-07-22T01:24:10Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a9d1cde. Configure here.}

…d-deleting mothership chats

waleedlatif1 · 2026-07-22T02:39:55Z

@greptile

waleedlatif1 · 2026-07-22T02:39:56Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 971d6a2. Configure here.}

waleedlatif1 · 2026-07-22T02:43:46Z

@greptile

waleedlatif1 · 2026-07-22T02:43:47Z

@cursor review

…edAt in chat drain

waleedlatif1 · 2026-07-22T02:49:35Z

@greptile

waleedlatif1 · 2026-07-22T02:49:36Z

@cursor review

waleedlatif1 · 2026-07-22T02:53:50Z

@greptile

waleedlatif1 · 2026-07-22T02:59:51Z

@greptile

waleedlatif1 · 2026-07-22T02:59:52Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 742ad5b. Configure here.}

feat(chat): soft-delete sidebar chats with restore from Recently Deleted

78976fc

waleedlatif1 requested a review from a team as a code owner July 22, 2026 00:48

greptile-apps Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/background/cleanup-soft-deletes.ts Outdated

Comment thread apps/sim/app/api/mothership/chats/[chatId]/restore/route.ts

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/mothership-chats.ts

Comment thread apps/sim/app/api/mothership/chats/[chatId]/route.ts

vercel Bot deployed to Preview July 22, 2026 00:52 View deployment

fix(chat): review round 1 — restore workspace authz, purge recheck, a…

ef9fe19

…rchived-list invalidation

vercel Bot temporarily deployed to Preview July 22, 2026 00:59 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/app/api/mothership/chats/[chatId]/route.ts

test(chat): update SSE handler assertions for workspaceLists invalida…

ee43a1a

…tion

vercel Bot temporarily deployed to Preview July 22, 2026 01:10 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/app/api/mothership/chats/[chatId]/restore/route.ts

fix(chat): bump updatedAt on restore, recheck retention cutoff in tas…

a92b532

…k cleanup

vercel Bot temporarily deployed to Preview July 22, 2026 01:17 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/background/cleanup-tasks.ts

fix(chat): drop explicit feedback delete in task cleanup — chat FK ca…

a9d1cde

…scade covers it

vercel Bot temporarily deployed to Preview July 22, 2026 01:24 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

test(chat): cover restore route; guard legacy copilot delete from har…

971d6a2

…d-deleting mothership chats

vercel Bot temporarily deployed to Preview July 22, 2026 02:40 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

chore: revert unintended bun.lock drift from worktree install

53ae4ba

greptile-apps Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/background/cleanup-soft-deletes.ts

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/lib/data-drains/sources/copilot-chats.ts

vercel Bot deployed to Preview July 22, 2026 02:48 View deployment

fix(cleanup): recheck workflow archive cutoff on delete; export delet…

742ad5b

…edAt in chat drain

vercel Bot temporarily deployed to Preview July 22, 2026 02:49 Inactive

greptile-apps Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/background/cleanup-tasks.ts

Comment thread apps/sim/app/api/mothership/chats/[chatId]/restore/route.ts

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread packages/db/migrations/0264_fat_ikaris.sql

cursor Bot reviewed Jul 22, 2026

View reviewed changes

waleedlatif1 merged commit 93fbf58 into staging Jul 22, 2026
20 checks passed

waleedlatif1 deleted the feat/chat-soft-delete-recently-deleted branch July 22, 2026 03:10

waleedlatif1 mentioned this pull request Jul 22, 2026

v0.7.41: email fixes, MCP fixes, gemini 3.6 flash, GitHub runners fallback, mothership experience improvements, soft delete chats #5835

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 22, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

vercel Bot commented Jul 22, 2026 •

edited

Loading

cursor Bot commented Jul 22, 2026 •

edited

Loading

greptile-apps Bot commented Jul 22, 2026 •

edited

Loading