improvement(logs): show Redacting status while PII masking runs#5855
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Backend: UI / API detail: Reviewed by Cursor Bugbot for commit 84b5766. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR surfaces PII masking as a distinct phase in execution logs. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(logs): never let the cosmetic redact..." | Re-trigger Greptile |
…g runs Log-stage PII redaction happens at persist time and can take minutes on large payloads, during which the Logs page showed the run as Running long after execution finished. The persist path now flips the log row to 'redacting' (guarded on 'running' so a concurrent cancellation is never clobbered) right before the masking work starts — only when the logs redaction stage is actually enabled — and the terminal update overwrites it with the final status. The Logs UI renders an amber non-filterable Redacting badge (row + details sidebar via the shared STATUS_CONFIG), keeps polling the detail query during the phase, and keeps resolving live progress markers. No migration: status is a free-text column, and the contract already types it as string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A1JYstmLHk9qMGyBDqYRcJ
26760f0 to
80f0783
Compare
Review finding: the status flip was awaited without failure isolation, so a transient DB error there rejected applyPiiRedaction before masking and the terminal update never ran. The write is display-only; catch and warn instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A1JYstmLHk9qMGyBDqYRcJ
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 84b5766. Configure here.
Summary
Type of Change
Testing
Tested manually against a local dev stack: ran a ~25MB function-output workflow with logs-stage redaction enabled and watched the log row sit in Redacting after execution finished, then flip to the final status. 332 lib/logs tests pass. lint and check:api-validation:strict pass.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01A1JYstmLHk9qMGyBDqYRcJ