[FEATURE] Add methods for querying MODS elements by parameters#38
Open
beatrycze-volk wants to merge 2 commits into
Open
[FEATURE] Add methods for querying MODS elements by parameters#38beatrycze-volk wants to merge 2 commits into
beatrycze-volk wants to merge 2 commits into
Conversation
Extracts common patterns for fetching single and multiple XML elements into new `getElement()` and `getElements()` helper methods in `BaseElement`. This reduces code duplication across various element-specific getter methods, enhancing maintainability and extensibility. Redundant private helper methods are removed from `BaseNameElement` by leveraging these new generic methods.
beatrycze-volk
added
feature
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Introduce new `get...ByParameters()` methods in elements. These methods provide a more flexible way to query MODS metadata by allowing searches using a combination of XPath fragments, attributes, and element values. The `Query` utility class is leveraged to construct dynamic XPath expressions based on the provided parameters, standardizing complex query generation. Existing single-parameter getter methods are also refactored to utilize generic element retrieval helpers.
beatrycze-volk
force-pushed
the
parameters3
branch
from
57b7c3e to
5c156bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #36