Plex 2359/solana log trigger bindings#485
Merged
silaslenihan merged 10 commits intoJun 12, 2026
Merged
Conversation
Signed-off-by: Silas Lenihan <sjl@lenihan.net>
silaslenihan
force-pushed
the
PLEX-2359/Solana-Log-Trigger-Bindings
branch
from
e753627 to
263492c
Compare
This reverts commit 263492c.
This was referenced Jun 11, 2026
silaslenihan
force-pushed
the
PLEX-2359/Solana-Log-Trigger-Bindings
branch
from
6cec99e to
3ef7150
Compare
silaslenihan
force-pushed
the
PLEX-2359/Solana-Log-Trigger-Bindings
branch
from
3ef7150 to
c069800
Compare
Contributor
|
Ready to approve once sdk is merged and bumped |
Collaborator
Author
@Unheilbar bumped |
Unheilbar
approved these changes
Jun 12, 2026
| methods := make([]Code, 0, len(g.idl.Events)) | ||
| for _, event := range g.idl.Events { | ||
| exportedName := tools.ToCamelUpper(event.Name) | ||
| m := Id("Encode"+exportedName+"Subkeys"). |
Contributor
There was a problem hiding this comment.
would we benefit from defining consts like Encode and SubKey and creating Id with some kind of config.New pattern or constructor?
Collaborator
Author
There was a problem hiding this comment.
seems a bit overkill and might make it a little less readable
patrickhuie19
approved these changes
Jun 12, 2026
Merged
via the queue into
capabilities-development
with commit Jun 12, 2026
65a8aeb
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
Supports: