Skip to content

refactor: consolidate lint fix registration logic#316

Open
solid-illiaaihistov wants to merge 2 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:285-refactor-registering-fixes-for-each-rule
Open

refactor: consolidate lint fix registration logic#316
solid-illiaaihistov wants to merge 2 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:285-refactor-registering-fixes-for-each-rule

Conversation

@solid-illiaaihistov

Copy link
Copy Markdown
Collaborator

Closes #285

@solid-illiaaihistov solid-illiaaihistov linked an issue Jul 7, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new RuleWithFixes interface to streamline the registration of lint rules and their associated quick fixes. Instead of manually registering fixes for each rule in SolidLintsPlugin.register, rules now implement RuleWithFixes and define their own fixes, which are dynamically registered in a loop. The feedback points out a redundant explicit cast in lib/main.dart due to Dart's automatic type promotion, and suggests reusing the existing ProducerGenerator typedef from package:analysis_server_plugin/registry.dart instead of redefining it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/main.dart
Comment thread lib/src/models/rule_with_fixes.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor registering fixes for each rule

1 participant