fix: canvas raw shader access#34
Open
CosmaVergari wants to merge 1 commit into
Open
Conversation
chiefcll
reviewed
Jun 19, 2026
| if ( | ||
| SHADERS_ENABLED && | ||
| props.shader && | ||
| !('program' in props.shader || 'render' in props.shader) // If not a raw shader |
Contributor
There was a problem hiding this comment.
Can we just look for render? Do we need both program and render?
Author
There was a problem hiding this comment.
I think that "render" is added in the Canvas shader node and "program" in the WebGL shader node, so we should check for the presence of any of the two
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Raw canvas shaders still go through the
convertToShaderfunction when being set on each node. However raw shaders already contain all the info for the shader to be rendered in theshaderprop.This is due to an error in the logic flow for Canvas (in WebGL it is correctly managed).
Solution: Apply the same logic that is used in WebGL, that is: when dealing with a raw canvas shader (
props.shader.renderis defined) do not callconvertToShader.