Skip to content

fix: move delete stream.then after dev-server branch to restore thenable #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsushanth wants to merge 1 commit into from
+5 −2
Closed

fix: move delete stream.then after dev-server branch to restore thenable #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/start/src/server/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,15 @@ export function createBaseHandler(

if (mode === "async") return await stream;

delete (stream as any).then;

// using TransformStream in dev can cause solid-start-dev-server to crash
// when stream is cancelled
if (globalThis.USING_SOLID_START_DEV_SERVER) return stream;

// remove thenable so h3/Cloudflare Workers do not await the stream object;
// must happen after the dev-server branch so the stream remains awaitable
// when returned to solid-start-dev-server above
delete (stream as any).then;

// returning stream directly breaks cloudflare workers
const { writable, readable } = new TransformStream();
stream.pipeTo(writable);
Expand Down
Loading