fix: convert path to file:// URL before ESM import in preview server#2164
Closed
tsushanth wants to merge 2 commits into
Closed
fix: convert path to file:// URL before ESM import in preview server#2164tsushanth wants to merge 2 commits into
tsushanth wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 5d09975 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Node's ESM loader requires import specifiers to be valid
file://URLs — a bare absolute path likeC:\Users\...\dist\server\entry-server.jstriggersERR_UNSUPPORTED_ESM_URL_SCHEMEbecause thec:prefix is not a recognised URL scheme.The
configurePreviewServermiddleware constructs the import path by concatenatingprocess.cwd()with the server entry filename. This works on POSIX but crashes on Windows. Wrapping the concatenated path withpathToFileURL(...).hreffromnode:urlproduces a validfile://URL on all platforms while remaining a no-op on POSIX (wherepathToFileURLstill returns a well-formedfile:///...string that the ESM loader accepts).Fixes #2140