Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/faraday/http_cache.rb
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,12 @@ def store(response)
end

def delete(request, response)
headers = %w[Location Content-Location]
headers.each do |header|
url = response.headers[header]
@strategy.delete(url) if url
response_headers = response.headers
if response_headers
%w[Location Content-Location].each do |header|
url = response_headers[header]
@strategy.delete(url) if url
end
end

@strategy.delete(request.url)
Expand Down
11 changes: 11 additions & 0 deletions spec/http_cache_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,17 @@
client.post('delete-with-content-location')
expect(client.get('get').body).to eq('2')
end

it 'invalidates the request url when the response has no headers' do
middleware = Faraday::HttpCache.new(->(env) { env }, logger: logger)
middleware.instance_variable_set(:@trace, [])
request = double(url: 'http://test/index')
response = double(headers: nil)
strategy = middleware.instance_variable_get(:@strategy)

expect(strategy).to receive(:delete).with('http://test/index')
expect { middleware.send(:delete, request, response) }.not_to raise_error
end
end

describe 'when acting as a shared cache' do
Expand Down