Keep original headers when build ErrorMessage in DefaultErrorMessageStrategy#11160
Open
mjd507 wants to merge 1 commit into
Open
Keep original headers when build ErrorMessage in DefaultErrorMessageStrategy#11160mjd507 wants to merge 1 commit into
DefaultErrorMessageStrategy#11160mjd507 wants to merge 1 commit into
Conversation
…Strategy` Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
artembilan
requested changes
Jul 6, 2026
| if (inputMessage instanceof Message) { | ||
| return new ErrorMessage(throwable, (Message<?>) inputMessage); | ||
| if (inputMessage instanceof Message<?> message) { | ||
| return new ErrorMessage(throwable, message.getHeaders(), message); |
Member
There was a problem hiding this comment.
OK. I don't see a harm in this, but still in consistency with our support and compatibility policy, we cannot accept this right now.
This is some kind of breaking change, so we aim it for the next minor 7.2 starting in August.
Please, consider to mention this in the class Javadoc.
Also describe such a logic in the dedicated Error Handling chapter of the doc: https://docs.spring.io/spring-integration/reference/error-handling.html.
When we switch to new version, we will also ask you to add a note about this change in the whats-new.adoc dedicated to that new 7.2 version.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setup
RequestHandlerRetryAdvicewith a recoverErrorMessageSendingRecoverer, after retry exhausted, theDefaultErrorMessageStrategywill build aErrorMessage, however it does not copy the original message headers.because I need the header values to do the error routing, so I think it is useful to keep it.