chore: add missing precision keywords in new blas/ext/base packages#12675
Draft
Planeshifter wants to merge 2 commits into
Draft
chore: add missing precision keywords in new blas/ext/base packages#12675Planeshifter wants to merge 2 commits into
blas/ext/base packages#12675Planeshifter wants to merge 2 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-06-06 14:40 PDT (f2640a213) and 2026-06-07 04:02 PDT (86dc341d3).Two new complex-precision BLAS extension packages landed without the precision keyword that every sibling carries:
blas/ext/basecaxpby/package.json— Fixdb04ac04(blas/ext/base/caxpby/package.json):"single"was missing from thekeywordsarray, inconsistent with sibling single-precision packagessaxpbyandcaxpy; appended"single"after"float32".zaxpby/package.json— Fix2aa1270d(blas/ext/base/zaxpby/package.json):"double"was missing from thekeywordsarray, inconsistent with sibling double-precision packagesdaxpbyandzaxpy; appended"double"after"float64".Related Issues
None.
Questions
None.
Other
Validation
Reviewed all 33 commits merged to
developin the window for typos, bugs, and style-guide violations. The audit was performed by four independent reviewer agents (two style, two bug) on top of a shared change summary.data.csv/data.jsonfiles, and intentional patterns like the masszeros→emptybenchmark setup change.False positives that were considered and dropped:
array/falses/lib/main.jsJSDoc@paramdefault — actual file already reads[dtype="bool"]; agent misread the source.dcunone/src/main.cmissingconston offset locals — theconstvs no-constpattern is mixed acrossblas/ext/baseC sources (81 vs 30 occurrences), so this is not an unambiguous style violation.swxsa/src/main.cusing literal5instead ofstatic const CBLAS_INT M = 5— siblingsapx(closest single-precision in-place unrolled-loop kernel) uses the literal as well, so the family pattern is not uniform.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Drafted by Claude Code as a follow-up audit of the last 24 hours of commits to
develop. Independent style and bug reviewer agents produced a candidate finding set; each surviving finding was manually re-verified against the relevant sibling reference packages before being applied. PR left in draft for human maintainer audit.@stdlib-js/reviewers
Generated by Claude Code