feat:Implement Dynamic Smagorinsky SGS model for LES (Germano-Lilly, local approximation)#2850
Open
Vamshimadhava wants to merge 4 commits into
Open
feat:Implement Dynamic Smagorinsky SGS model for LES (Germano-Lilly, local approximation)#2850Vamshimadhava wants to merge 4 commits into
Vamshimadhava wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements the CDynamicSmagorinskyModel::ComputeEddyViscosity_3D method in sgs_model.inl.
The implementation follows the Germano–Lilly dynamic procedure using a single-point approximation of the test filter, making it compatible with SU2's unstructured DG FEM solver architecture, which does not expose neighbor stencils at the SGS model level.
The Lilly least-squares estimator is used to compute the local Smagorinsky coefficient (Cs²), which is clipped to zero to prevent backscatter.
Related Work
Germano, M., Piomelli, U., Moin, P., & Cabot, W. H. (1991). A dynamic subgrid-scale eddy viscosity model. Physics of Fluids A, 3(7), 1760–1765.
Lilly, D. K. (1992). A proposed modification of the Germano subgrid-scale closure method. Physics of Fluids A, 4(3), 633–635.
Related to the existing ones CSmagorinskyModel and CWALEModel implementations in the same file.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.