Finish personal->home role rename (gitconfig.sh + fish prompt)#14
Merged
Conversation
Commit e3e5027 renamed DOTPICKLES_ROLE personal->home but missed two consumers: - gitconfig.sh still had a `personal)` case and no `home)` case, so it fell through to `*)` and exited "Unexpected role: home" on a home machine. Renamed the case to `home)`. - config/fish/config.fish set DOTPICKLES_ROLE, but fish sources conf.d/ before config.fish, and conf.d/starship-init.fish reads the role at init time to build STARSHIP_CTX. The role was always unset at prompt-build time, so the prompt baked in the `personal` fallback. Moved role detection to conf.d/dotpickles-role.fish (sorts before starship-init), removed it from config.fish, and fixed the stale `personal` fallback to `home`. Captured the why in docs: a "Load Order Gotcha" section in config/fish/CLAUDE.md, the conf.d ordering note + updated fish path in architecture.md, and added the two missed consumers plus the conf.d placement rule to ADR 0035. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Commit e3e5027 renamed
DOTPICKLES_ROLEfrompersonaltohomebut missed two consumers. This finishes the job and documents the why.The two bugs
gitconfig.shstill had apersonal)case and nohome)case, so on a home machine it fell through to*)and exited withUnexpected role: home. Renamed the case tohome).The fish prompt showed
personaleven though the real role washome. Root cause: fish sourcesconf.d/*.fishbeforeconfig.fish, butDOTPICKLES_ROLEwas set inconfig.fish.conf.d/starship-init.fishreads the role at init time to buildSTARSHIP_CTX, so it always saw the var unset and baked in thepersonalfallback.Fix:
conf.d/dotpickles-role.fish(sorts beforestarship-init, so the role is set in time)config.fishor echo personalfallback toor echo homeDocs captured
config/fish/CLAUDE.md: new "Load Order Gotcha" sectiondoc/architecture.md: updated fish detection path + conf.d ordering notegitconfig.shand the starship fallback to the known-consumers list, plus a "set the role in conf.d, not config.fish" subsectionVerification
bash -n gitconfig.shpasses;casenow matcheshomeDOTPICKLES_ROLEresolves tohome, prompt ctx ishomenpm run lint(nonode_modulesin this env); pre-commit Prettier hook handles markdown formatting🤖 Generated with Claude Code