[pull] master from robotframework:master#145
Open
pull[bot] wants to merge 2032 commits into
Open
Conversation
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
Hopefully this doesn't make tests flakey...
- Disable current timeouts when running keyword teardown to avoid them stopping execution. - After teardown, check has any of timeouts exceeded during it. - Timeouts set inside teardown are used normally. Fixes #5474.
Also round time left in the "timeout active" debug message to three decimals.
The value should be omitted altogether or '0' used instead. Also add default value to `Get Substring` keyword's `start` argument to actually allow omitting the value. Fixes #5537.
Argument conversion handles conversion for us.
- Use templates to avoid duplication - Make template keywords more generic
This was already done with `Split To Lines` and `Get Substring`, but now it is also done with `Split String`, `Split String From Right` and `Generate Random String`. Fixes #5537.
Fixes #5568. Also enhance comments about other deprecations in RF 7.4. Now all have a TODO about removing in RF 9. Possibly those that affect signatures (`Literal[""]`) could be removed already earlier, with others there's no real hurry.
Also some fine-tuning.
Earlier no conversion was attempted if argument was typed like `arg: int | object`. Nowadays conversion to types before `object` is attempted. Fixes #5529. We plant to change `Any` conversion this way as well. See #5571 for details. Also simplify `Should Be Equal` typing. The old approach would have caused issues if `Any` handling was changed.
Includes tests for: - parsing docstring - saving results to XML and JSON specs using both HTML and RAW docs - parsing XML and JSON specs Part if #5604.
isinstance(item, IOBase) triggered ABC machinery that accessed the object's __class__, which raised AttributeError for non-Python objects from some vendor SDKs (e.g. Squish). Check issubclass(type(item), IOBase) against the type instead, so type_name degrades gracefully and the real conversion error surfaces instead of a masking AttributeError.
- Allow bold/italics formatting with headers - Allow code-style formatting with argument names - Ignore positional-only marker similarly as kwo marker - Strip spaces from return documentation - Refactor
Includes adding longer example using Markdown. Libdoc HTML files generated based on the examples still need to be updated/added. Part of #5604.
Needed because table of contents does not contain importing section anymore (#5697)
Part of argument and return value documentation (#5604)
Part of #5703. HTML UI code still needs to be adjusted.
There was a bug in docstring info parsing (#5604) if docstring for `__init__` was get via `get_keyword_names`. Parsing `__init__` docstrings was not tested at all, so tests were added also for the non-dynamic case.
Tags are now handled by the same parser that handles argument, return value and exception documentation (#5604). This means all such information is handled consistently (#5707). Not having an empty row before `Tags:` is deprecated. `robot.utils.split_tags_from_doc` became unnecessary and was deprecated as well.
This happens when a value without `__class__` is tested against `collections.abc` classes. See #5699 about problems caused by this in type conversion. Such objects could surface in other places than in type conversion as well. Handling them in `is_list_like`, `is_dict_like` and in few other places will likely help, but problems can still occur. I really hope `collections.abc` classes are fixed so that they don't fail like this. See python/cpython#153772.
Also document in API docs that RF 7.5 doesn't actually support reporting deprecation warnings yet. Fixes #5668.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )