audio: comp_buffer: make allocations from the passed memory context#10951
Open
serhiy-katsyuba-intel wants to merge 1 commit into
Open
audio: comp_buffer: make allocations from the passed memory context#10951serhiy-katsyuba-intel wants to merge 1 commit into
serhiy-katsyuba-intel wants to merge 1 commit into
Conversation
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
mmaka1 and
plbossart
as code owners
To ensure the buffer is not left outside the module's memory domain, the payload allocation must be made from the supplied context instead of always calling rballoc_align(). This fixes a crash during bind processing when running a test with a userspace DP module on a secondary core. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates buffer payload allocation/freeing to honor the passed mod_alloc_ctx, keeping allocations within the module’s memory domain and avoiding crashes during bind processing (notably with userspace DP modules on secondary cores).
Changes:
- Switch payload allocation/free paths to prefer
sof_ctx_alloc/freewhen analloccontext is provided, falling back torballoc_align/rfreeotherwise. - Replace
#ifdef CONFIG_SOF_USERSPACE_LLblocks with runtime selection plus assertions usingIS_ENABLED(CONFIG_SOF_USERSPACE_LL).
serhiy-katsyuba-intel
force-pushed
the
userspace_crash_fix2
branch
from
5cca57d to
444d490
Compare
lgirdwood
approved these changes
Jun 22, 2026
Member
|
@serhiy-katsyuba-intel can you respond to copilot, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure the buffer is not left outside the module's memory domain, the payload allocation must be made from the supplied context instead of always calling rballoc_align().
This fixes a crash during bind processing when running a test with a userspace DP module on a secondary core.