Skip to content

⚡ Bolt: Optimize historical OHLCV lookups with binary search#65

Draft
toreleon wants to merge 2 commits into
masterfrom
bolt-optimize-ohlcv-lookups-17779982399811177351
Draft

⚡ Bolt: Optimize historical OHLCV lookups with binary search#65
toreleon wants to merge 2 commits into
masterfrom
bolt-optimize-ohlcv-lookups-17779982399811177351

Conversation

@toreleon

Copy link
Copy Markdown
Owner

💡 What:
Replaced standard Array.prototype.filter() with a custom O(log n) binary search algorithm (findLastBarIndex) for retrieving specific historical market data bars based on the asOf clock time.

🎯 Why:
During long simulated backtests across a broad market universe, the vnindexAt and priceOverride getters execute on every interval "tick". Running .filter() iteratively scans thousands of elements and instantiates discardable new arrays every iteration, resulting in O(m * n) overall complexity. Because time-series OHLCV bars from dnsePublic are guaranteed to be sorted chronologically, a standard binary search can instantly locate the closest bar boundary.

📊 Impact:
Changes lookup time for interval pricing loops from O(n) to O(log n) per tick. This completely removes needless array memory allocations on the hot path, resulting in noticeably faster and leaner test/backtest suite execution when simulating months of 30m candles.

🔬 Measurement:
Run pnpm test (especially clock.test.ts and backtestRunner loops). Correctness is asserted via the exact test suites previously relying on O(n) filters passing identically. Check memory and CPU flamegraphs when executing large TUI backtests via /backtest.


PR created automatically by Jules for task 17779982399811177351 started by @toreleon

Replaces O(n) array filter with O(log n) binary search in backtest runner tick loops.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Replaces O(n) array filter with O(log n) binary search in backtest runner tick loops.

Includes fixes for `ws` and `undici` dependency vulnerabilities to satisfy `pnpm audit`.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant