feat(push): end-to-end ingest correlation id — print it on submit (backend#1028 item 3)#245
Open
LukasWodka wants to merge 1 commit into
Open
feat(push): end-to-end ingest correlation id — print it on submit (backend#1028 item 3)#245LukasWodka wants to merge 1 commit into
LukasWodka wants to merge 1 commit into
Conversation
…em 3) The idempotency key the CLI already sends is becoming the end-to-end ingest correlation id: jobs-manager derives the Job name from it, labels every spawned resource with it, and (client-runtime) stamps it into the ingestor container as TRACEBLOC_INGEST_CORRELATION_ID, where the ingestor (data-ingestors) logs it and carries it into the backend registration payload. The CLI was the only layer that never showed the key, so the customer had no copy of the one string that threads all layers together. Print it as a hint line on every submit path — fresh and replay (a replayed run is exactly when you reach for the id to find the already-running Job). No wire change: the key was already in the POST body. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
👋 Heads-up — Code review queue is at 51 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prints the run's correlation id on
tracebloc dataset push(backend#1028 item 3). The idempotency key the CLI already generates and sends is becoming the end-to-end ingest correlation id — jobs-manager derives the Job name from it, labels every spawned resource with it, and stamps it into the ingestor container asTRACEBLOC_INGEST_CORRELATION_ID; the ingestor logs it and ships it in the backend registration payload. The CLI was the only layer that never showed the key, so the customer had no copy of the one string that threads all layers together. OneHintfline on every submit path (fresh and replay) fixes that. No wire change.Related
Ref tracebloc/backend#1028 (item 3). Sibling PRs: tracebloc/client-runtime#176 (stamps the Job env) and tracebloc/data-ingestors#368 (ingestor honours it).
The cross-repo contract
crypto/randhex fromBuildRequest, or the customer's--idempotency-key; jobs-manager caps it at 64 chars).Correlation id: <key>after the submit announcement — on replay too, since a replayed run is exactly when you reach for the id to find the already-running Job.TRACEBLOC_INGEST_CORRELATION_ID=<key>on the Job; data-ingestors#368 validates it (^[A-Za-z0-9._-]{1,64}$, fallback = today's behaviour), logsCorrelation id: <id> (ingestor_id: <uuid>), and landsmeta_data.correlation_idon the backend dataset row.Test plan
TestRun_PrintsCorrelationId_GeneratedKey(auto-generated key echoed) andTestRun_PrintsCorrelationId_OverrideAndReplay(--idempotency-keyoverride echoed verbatim on the replay path).make ci(vet +go test -race -cover ./...+ lint + fmt-check + schema-check) → all green.Adjacency
Open PR #235 also touches
internal/submit/submit_test.go(lint/dead-export cleanup) — my additions are new test funcs, worst case a trivial rebase. #232 touchesinternal/submit/summary.goonly; this PR deliberately does not change the summary banner or its parser.Checklist
🤖 Generated with Claude Code
Note
Low Risk
Output-only hint line in the submit flow; no changes to auth, request payloads, or cluster behavior.
Overview
After a successful submit,
tracebloc dataset pushnow printsCorrelation id: <idempotency key>on every path (fresh submit and replay), right after the existing success/replay message. The value is the same idempotency key already sent to jobs-manager—no API or wire changes.Tests assert the line appears for an auto-generated key and for an explicit
--idempotency-keyon replay.Reviewed by Cursor Bugbot for commit 7ab32a8. Bugbot is set up for automated code reviews on this repo. Configure here.