Fix tus upload rejection handling#438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
API2 PagerDuty incident Q33YSSJS2BXHOF exposed that a transient tus create-upload failure can reject the caller-facing
startPromiseand also leave the SDK's internal upload URL/completion bookkeeping promises rejected without handlers. In API2 that second, duplicate rejection reached the process-wideunhandledRejectionhandler after the originalcreateAssembly()failure had already been caught and reported.Changes
onError.@transloadit/node,@transloadit/mcp-server, andtransloaditper release-coupling policy.Tests
yarn workspace @transloadit/node test:unit --run ./test/unit/tus.test.tsyarn checkRelated API2 pager PR: https://github.com/transloadit/api2/pull/8307